Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creating first few integration tests #571

Merged

Conversation

henriqueholtz
Copy link
Member

@henriqueholtz henriqueholtz commented Nov 17, 2024

  • Built on top of PR 570
  • Created a integration tests, using InMemory database (in the future we can use Testcontainers for .NET with the following tests:
    • Book: [GET] api/book/AvailableBooks_All
    • Meetup:
      • [GET] api/Meetup?page={page}&pageSize={pageSize}&upcoming={upcoming} (7x)
      • [GET] api/Meetup/search?criteria={criteria} (3x)
    • Category: [GET] api/category

All these new tests will be already executed on Github Action.

@AppVeyorBot
Copy link

@AppVeyorBot
Copy link

@raffacabofrio
Copy link
Member

Salve amigão @henriqueholtz. Desculpe a demora. Parece que tem alguns conflitos nessa PR. Pode dar uma olhada?

@henriqueholtz
Copy link
Member Author

Salve amigão @henriqueholtz. Desculpe a demora. Parece que tem alguns conflitos nessa PR. Pode dar uma olhada?

Opa, ainda está como draft (não está finalizado), to fazendo aos poucos haha

@AppVeyorBot
Copy link

@henriqueholtz henriqueholtz marked this pull request as ready for review December 18, 2024 00:24
@AppVeyorBot
Copy link

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)
B Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@raffacabofrio
Copy link
Member

salve @henriqueholtz já podemos fazer o code review e merge?

@henriqueholtz
Copy link
Member Author

salve @henriqueholtz já podemos fazer o code review e merge?

Opa, sim, está pronto p/ review...

/// <summary>
/// Only should be used for integration tests
/// </summary>
public static bool IgnoreMigrations = false;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pode falar um pouco desse cara? Em que contexto ele fica true?

@raffacabofrio
Copy link
Member

Amigão @henriqueholtz outra pergunta. Em que momento esse teste vai rodar?

@raffacabofrio raffacabofrio merged commit dd77fad into SharebookBR:develop Dec 24, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants