Feature/azure whisper #11
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Create an Azure Whisper service * test workflows/ci * added testing files to gitignore * update 'model' to 'deployment_id' * tidy up file length to pass linting * change import block to abide by linting rules * use isort to sort file imports * use ruff instead to try fix linting issues * use poetry to reformat file * add base_url * remove extra files previously added from .gitignore * add extra comments and test env variables * reformat file * Add better docstrings and work on PR review comments * tidy file for linting * reformat audio file * add better docstring * change os.splitext * add other commented on features from PR review * Change Tuple type * add Tuple to error message * add file type checking and correct docstring * update docstring and remove chunking section to ensure 25MB limit * update file size checking to use `os.path.getsize()` * reformat file * change `os.path.getsize()` to have str input * work on PR review comments and change file reading * reformat file for linting * ensure blob.path is string * add attempt at unit test * change parameter name to be correct * add client property to parser to allow easier testing and initialisation * updated mockclient parameters naming in test * reformat test file for linting * reformat test * work on second unit test * change how iterator is handled * add data parameter to blob * add first test to second test * change file to try and fix errors * change decorator to patch differently * add PR review changes and reformat test file * reformat patch decorator * reformat files for linting * change patch decorator to match module path * hardcode file path into patch decorator * update patch decorator again * add working unit tests for parser and test file * add test function type annotations * add parameter type annotations * create docs for `AzureOpenAIWhisperParser`
This reverts commit b704658.
test workflows/ci added testing files to gitignore update 'model' to 'deployment_id' tidy up file length to pass linting change import block to abide by linting rules use isort to sort file imports use ruff instead to try fix linting issues use poetry to reformat file add base_url remove extra files previously added from .gitignore add extra comments and test env variables reformat file Add better docstrings and work on PR review comments tidy file for linting reformat audio file add better docstring change os.splitext add other commented on features from PR review Change Tuple type add Tuple to error message add file type checking and correct docstring update docstring and remove chunking section to ensure 25MB limit update file size checking to use `os.path.getsize()` reformat file change `os.path.getsize()` to have str input work on PR review comments and change file reading reformat file for linting ensure blob.path is string add attempt at unit test change parameter name to be correct add client property to parser to allow easier testing and initialisation updated mockclient parameters naming in test reformat test file for linting reformat test work on second unit test change how iterator is handled add data parameter to blob add first test to second test change file to try and fix errors change decorator to patch differently add PR review changes and reformat test file reformat patch decorator reformat files for linting change patch decorator to match module path hardcode file path into patch decorator update patch decorator again add working unit tests for parser and test file add test function type annotations add parameter type annotations create docs for `AzureOpenAIWhisperParser`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a draft PR after I accidentally merged the otherone, I've opened this just to check tests still run.