help util: replace jtextutils with asciitable #415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* main motivation: jtextutils became vulnerable because the domain `com.massisframework` is available for sale... * also: asciitable is far better IMO
|
cc @Ferada |
maltek
reviewed
Feb 6, 2024
| table.addRule() | ||
| table.getContext.setGridTheme(TA_GridThemes.FULL) | ||
| table.setTextAlignment(TextAlignment.LEFT) | ||
| table.render(width) |
There was a problem hiding this comment.
what happens when the contents are wider than 120 characters? (e.g. dataflows are wider than that all the time)
There was a problem hiding this comment.
It get's split up into several lines. There's quite a few options, I went for left alignment for the text.
https://github.com/vdmeer/asciitable/?tab=readme-ov-file#text-alignment-1
There was a problem hiding this comment.
(previously, the table would just expand in width to the widest cell)
|
For comparison: in joern: new: |
|
n.b. I'm working on a followup change that'll pass down the terminal size to the text table |
maltek
approved these changes
Feb 6, 2024
|
Thanks for looking into that 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
com.massisframeworkis available for sale...