Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

table rendering: use minimum width #417

Merged
merged 1 commit into from
Feb 9, 2024

Conversation

mpollmeier
Copy link
Contributor

some terminal emulators (e.g. on github actions CI) report to have a width of 0...
that doesn't work for rendering a table, so we compensate by using a minimum width

from the joern testDistro.sh output on github actions:

Exception in thread "main" java.lang.ExceptionInInitializerError
	at io.joern.joerncli.console.ReplBridge$.predefLines(ReplBridge.scala:17)
	at io.joern.console.BridgeBase.createPredefFile(BridgeBase.scala:211)
	at io.joern.console.BridgeBase.createPredefFile$(BridgeBase.scala:45)
	at io.joern.joerncli.console.ReplBridge$.createPredefFile(ReplBridge.scala:6)
	at io.joern.console.ScriptExecution.runScript(BridgeBase.scala:261)
	at io.joern.console.ScriptExecution.runScript$(BridgeBase.scala:254)
	at io.joern.joerncli.console.ReplBridge$.runScript(ReplBridge.scala:6)
	at io.joern.console.BridgeBase.run(BridgeBase.scala:194)
	at io.joern.console.BridgeBase.run$(BridgeBase.scala:45)
	at io.joern.joerncli.console.ReplBridge$.run(ReplBridge.scala:6)
	at io.joern.joerncli.console.ReplBridge$.main(ReplBridge.scala:11)
	at io.joern.joerncli.console.ReplBridge.main(ReplBridge.scala)
Caused by: java.lang.IllegalArgumentException: wrong width argument: width must allow for borders
	at de.vandermeer.asciitable.CWC_AbsoluteEven.calculateColumnWidths(CWC_AbsoluteEven.java:45)
	at de.vandermeer.asciitable.AT_Renderer.renderAsCollection(AT_Renderer.java:167)
	at de.vandermeer.asciitable.AT_Renderer.render(AT_Renderer.java:128)
	at de.vandermeer.asciitable.AsciiTable.render(AsciiTable.java:191)
	at overflowdb.traversal.help.Table.render(Table.scala:26)
	at io.joern.console.Help$.overview(Help.scala:36)
	at io.joern.console.Help$.codeForHelpCommand(Help.scala:70)
	at io.joern.joerncli.console.Predefined$.<clinit>(Predefined.scala:30)
	... 12 more

some terminal emulators (e.g. on github actions CI) report to have a width of 0...
that doesn't work for rendering a table, so we compensate by using a minimum width

from the joern testDistro.sh output on github actions:
```
Exception in thread "main" java.lang.ExceptionInInitializerError
	at io.joern.joerncli.console.ReplBridge$.predefLines(ReplBridge.scala:17)
	at io.joern.console.BridgeBase.createPredefFile(BridgeBase.scala:211)
	at io.joern.console.BridgeBase.createPredefFile$(BridgeBase.scala:45)
	at io.joern.joerncli.console.ReplBridge$.createPredefFile(ReplBridge.scala:6)
	at io.joern.console.ScriptExecution.runScript(BridgeBase.scala:261)
	at io.joern.console.ScriptExecution.runScript$(BridgeBase.scala:254)
	at io.joern.joerncli.console.ReplBridge$.runScript(ReplBridge.scala:6)
	at io.joern.console.BridgeBase.run(BridgeBase.scala:194)
	at io.joern.console.BridgeBase.run$(BridgeBase.scala:45)
	at io.joern.joerncli.console.ReplBridge$.run(ReplBridge.scala:6)
	at io.joern.joerncli.console.ReplBridge$.main(ReplBridge.scala:11)
	at io.joern.joerncli.console.ReplBridge.main(ReplBridge.scala)
Caused by: java.lang.IllegalArgumentException: wrong width argument: width must allow for borders
	at de.vandermeer.asciitable.CWC_AbsoluteEven.calculateColumnWidths(CWC_AbsoluteEven.java:45)
	at de.vandermeer.asciitable.AT_Renderer.renderAsCollection(AT_Renderer.java:167)
	at de.vandermeer.asciitable.AT_Renderer.render(AT_Renderer.java:128)
	at de.vandermeer.asciitable.AsciiTable.render(AsciiTable.java:191)
	at overflowdb.traversal.help.Table.render(Table.scala:26)
	at io.joern.console.Help$.overview(Help.scala:36)
	at io.joern.console.Help$.codeForHelpCommand(Help.scala:70)
	at io.joern.joerncli.console.Predefined$.<clinit>(Predefined.scala:30)
	... 12 more
```
@mpollmeier mpollmeier merged commit ad1d1cd into master Feb 9, 2024
1 check passed
@delete-merged-branch delete-merged-branch bot deleted the michael/table-rendering-minimum-width branch February 9, 2024 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants