feature: 숙소 조회 시, 객실 최대 인원과 최대 page count를 응답에 포함해 보내는 API를 구현합니다. #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix: ssh 키 수정
feat: 상품 전체 조회 및 상세 조회 기능 구현
…into feature/product
- 총 예약 인원 'totalPeople', 방문 시작일 'startDate', 방문 마지막일 'endDate' 필드 추가
- 테이블 여부 컬럼인 table이 예약어여서 변경
돼 테스트가 안되는 점 수정
- Open API에서 받아온 데이터에 맞게 자료형 수정
feat: Open API에서 더 많은 정보를 활용하도록 구현
JeongUijeong
requested changes
Dec 11, 2023
Comment on lines
18
to
24
| @Query(value = "SELECT p FROM Product as p " | ||
| + "JOIN FETCH p.rooms as r " | ||
| + "JOIN FETCH p.address as addr " | ||
| + "WHERE p.name LIKE %:#{#searchKeywordRequest.productName}% " | ||
| + "AND addr.detailAddress LIKE %:#{#searchKeywordRequest.address}% " | ||
| + "AND p.category in :#{#searchKeywordRequest.category} " | ||
| + "AND r.capacity >= :#{#searchKeywordRequest.capacity}") |
There was a problem hiding this comment.
QueryDSL을 통해 Java 문법으로 쿼리를 날릴 수 있습니다! 마침 저희 프로젝트에서도 사용하도록 설정되어 있으니, 사용해보시는 게 좋을 것 같습니다~~
There was a problem hiding this comment.
설정도 되있으니 QueryDSL 사용해서 하겠습니다!
src/test/resources/application.yml
Outdated
There was a problem hiding this comment.
secret 값들이 모두 올라가 있습니다..! 해당 커밋 남지 않도록 수정해주세요!!
There was a problem hiding this comment.
오호...저게 왜 올라갔지 수정하겠습니다.
wocjf0513
force-pushed
the
feature/product-capacity-search
branch
from
8e5f4f5 to
b849287
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #103 을 참고해주세요!
💡 Motivation
📌 Changes
🫱🏻🫲🏻 To Reviewers