Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature, test: 상세 조회- 보유수량 및 roomCode, 장바구니 및 예약 API 수정 #112

Merged
merged 5 commits into from
Dec 12, 2023
Merged

feature, test: 상세 조회- 보유수량 및 roomCode, 장바구니 및 예약 API 수정 #112

merged 5 commits into from
Dec 12, 2023

Conversation

wocjf0513
Copy link
Contributor

💡 Motivation

  • ERD가 바뀌고, 같은 방 코드를 가진 방 수량을 체크해서 상세 조회 시 뿌려주기로 했기에, 위와 같은 내용들이 수정됐습니다.

📌 Changes

  • 상세 조회- 보유수량 및 roomCode 응답
  • 장바구니 API 수정 (id -> roomCode)
  • 예약 API 수정 (roomCode)

🫱🏻‍🫲🏻 To Reviewers

  • 화이팅!

@wocjf0513 wocjf0513 self-assigned this Dec 12, 2023
@wocjf0513 wocjf0513 added 🛠️feature 기능 개발 ✅Test test 관련 labels Dec 12, 2023
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 12, 2023 •
edited
Loading

Test Results

87 tests  ±0   87 ✔️ ±0   4s ⏱️ -1s
51 suites ±0     0 💤 ±0 
51 files   ±0     0 ❌ ±0 

Results for commit 67dfc3e. ± Comparison against base commit ed7ff1c.

♻️ This comment has been updated with latest results.

jo0oy
jo0oy approved these changes Dec 12, 2023
View reviewed changes
Copy link
Contributor

@jo0oy jo0oy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다아아~👍🏻

JeongUijeong
JeongUijeong approved these changes Dec 12, 2023
View reviewed changes
Copy link
Contributor

@JeongUijeong JeongUijeong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨어용

@wocjf0513 wocjf0513 merged commit 4acba0a into develop Dec 12, 2023
3 checks passed
@wocjf0513 wocjf0513 deleted the feature/product-get-products branch December 12, 2023 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JeongUijeong JeongUijeong JeongUijeong approved these changes

@jo0oy jo0oy jo0oy approved these changes

Assignees

@wocjf0513 wocjf0513

Labels
🛠️feature 기능 개발 ✅Test test 관련
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wocjf0513 @jo0oy @JeongUijeong