Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: 즐겨찾기 응답 시 isLast 필드 제외 #120

Merged
merged 2 commits into from
Dec 13, 2023
Merged

refactor: 즐겨찾기 응답 시 isLast 필드 제외 #120

merged 2 commits into from
Dec 13, 2023

Conversation

JeongUijeong
Copy link
Contributor

💡 Motivation

  • FE 에서 isLast 필드가 불필요하다는 피드백을 주셔서 해당 필드를 삭제하고자 합니다.

📌 Changes

  • 즐겨찾기 응답 시 isLast 필드 제외

🫱🏻‍🫲🏻 To Reviewers

  • isLast만 삭제 했습니다. 승인 부탁드려요!

@JeongUijeong JeongUijeong added 🚧refactoring 리팩토링 ✅Test test 관련 labels Dec 13, 2023
@JeongUijeong JeongUijeong self-assigned this Dec 13, 2023
@github-actions GitHub Actions
Copy link

Test Results

100 tests  ±0   100 ✔️ ±0   5s ⏱️ ±0s
  62 suites ±0       0 💤 ±0 
  62 files   ±0       0 ❌ ±0 

Results for commit 9d228d6. ± Comparison against base commit 517bee9.

jo0oy
jo0oy approved these changes Dec 13, 2023
View reviewed changes
Copy link
Contributor

@jo0oy jo0oy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

왕왕 수고헀어요 🙂

wocjf0513
wocjf0513 approved these changes Dec 13, 2023
View reviewed changes
Copy link
Contributor

@wocjf0513 wocjf0513 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생했어요

@JeongUijeong JeongUijeong merged commit a6405db into develop Dec 13, 2023
3 checks passed
@JeongUijeong JeongUijeong deleted the feature/favorite branch December 13, 2023 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wocjf0513 wocjf0513 wocjf0513 approved these changes

@jo0oy jo0oy jo0oy approved these changes

Assignees

@JeongUijeong JeongUijeong

Labels
🚧refactoring 리팩토링 ✅Test test 관련
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JeongUijeong @jo0oy @wocjf0513