Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature, test: 전체 조회 및 상세 조회시, 즐겨찾기 여부 추가 응답!! #124

Merged
merged 2 commits into from
Dec 13, 2023
Merged

feature, test: 전체 조회 및 상세 조회시, 즐겨찾기 여부 추가 응답!! #124

merged 2 commits into from
Dec 13, 2023

Conversation

wocjf0513
Copy link
Contributor

@wocjf0513 wocjf0513 commented Dec 13, 2023 •
edited
Loading

💡 Motivation

  • 즐겨찾기 기능이 추가되서, 숙소 조회 및 상세 조회에서 즐겨찾기 여부가 필요합니다.

📌 Changes

  • 전체 조회 및 상세 조회 시, 응답 메세지에 즐겨찾기 여부 추가
  • 즐겨찾기 여부를 판단하기 위한 메소드 추가 (ProductService)
  • 즐겨찾기 여부를 조회하기 위한 통합 테스트 작성

🫱🏻‍🫲🏻 To Reviewers

  • 화이팅!

Close #122

@wocjf0513 wocjf0513 self-assigned this Dec 13, 2023
@wocjf0513 wocjf0513 added 🛠️feature 기능 개발 ✅Test test 관련 labels Dec 13, 2023
@github-actions GitHub Actions
Copy link

Test Results

104 tests  +1   104 ✔️ +1   5s ⏱️ ±0s
  62 suites ±0       0 💤 ±0 
  62 files   ±0       0 ❌ ±0 

Results for commit 00a419a. ± Comparison against base commit 64abe35.

jo0oy
jo0oy approved these changes Dec 13, 2023
View reviewed changes
Copy link
Contributor

@jo0oy jo0oy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다!

@wocjf0513 wocjf0513 merged commit ddd8b08 into develop Dec 13, 2023
3 checks passed
@wocjf0513 wocjf0513 deleted the featrue/product-favorite branch December 13, 2023 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jo0oy jo0oy jo0oy approved these changes

@JeongUijeong JeongUijeong Awaiting requested review from JeongUijeong

Assignees

@wocjf0513 wocjf0513

Labels
🛠️feature 기능 개발 ✅Test test 관련
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wocjf0513 @jo0oy