Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: 장바구니 추가 시, 날짜 검증 수정 및 querydsl 사용 #128

Merged
merged 1 commit into from
Dec 13, 2023
Merged

fix: 장바구니 추가 시, 날짜 검증 수정 및 querydsl 사용 #128

merged 1 commit into from
Dec 13, 2023

Conversation

wocjf0513
Copy link
Contributor

💡 Motivation

  • 깜빡하고 장바구니 추가 시, 날짜에 따른 보유 수량보다 못 넣게 해야 되는데 검증을 안 해서 구현했습니다.

📌 Changes

  • 상품 A 보유수량 >= 장바구니에 있는 상품 A 개수를 확인하는 API 구현
  • 장바구니에 있는 상품 A개수를 countSelect하는 querydsl repository 구현

🫱🏻‍🫲🏻 To Reviewers

  • 어리고 싶다.

@wocjf0513 wocjf0513 self-assigned this Dec 13, 2023
@wocjf0513 wocjf0513 added 🛠️feature 기능 개발 🧑🏻‍🔧fix 오류 수정 labels Dec 13, 2023
@github-actions GitHub Actions
Copy link

Test Results

104 tests  ±0   104 ✔️ ±0   5s ⏱️ ±0s
  62 suites ±0       0 💤 ±0 
  62 files   ±0       0 ❌ ±0 

Results for commit b11c6ad. ± Comparison against base commit 25294f6.

jo0oy
jo0oy approved these changes Dec 13, 2023
View reviewed changes
Copy link
Contributor

@jo0oy jo0oy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고했어요~~👍🏻

JeongUijeong
JeongUijeong approved these changes Dec 13, 2023
View reviewed changes
Copy link
Contributor

@JeongUijeong JeongUijeong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니당~ 아직 늙진 않았어요~ 👍🏻

@wocjf0513 wocjf0513 merged commit 0397988 into develop Dec 13, 2023
3 checks passed
@wocjf0513 wocjf0513 deleted the featrue/product-favorite branch December 13, 2023 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JeongUijeong JeongUijeong JeongUijeong approved these changes

@jo0oy jo0oy jo0oy approved these changes

Assignees

@wocjf0513 wocjf0513

Labels
🛠️feature 기능 개발 🧑🏻‍🔧fix 오류 수정
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wocjf0513 @jo0oy @JeongUijeong