Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: 즐겨찾기 도메인 리팩토링 #133

Merged
merged 4 commits into from
Dec 14, 2023
Merged

refactor: 즐겨찾기 도메인 리팩토링 #133

merged 4 commits into from
Dec 14, 2023

Conversation

JeongUijeong
Copy link
Contributor

@JeongUijeong JeongUijeong commented Dec 14, 2023 •
edited
Loading

💡 Motivation

  • 즐겨찾기 도메인 리팩토링이 필요합니다.

📌 Changes

  • 불필요한 로그 삭제
  • 테스트 코드 리팩토링
  • 생성자 접근 레벨 조정

🫱🏻‍🫲🏻 To Reviewers

  • 승인 부탁드려요~🤍

@JeongUijeong JeongUijeong added the 🚧refactoring 리팩토링 label Dec 14, 2023
@JeongUijeong JeongUijeong self-assigned this Dec 14, 2023
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 14, 2023 •
edited
Loading

Test Results

105 tests  ±0   105 ✔️ ±0   5s ⏱️ ±0s
  62 suites ±0       0 💤 ±0 
  62 files   ±0       0 ❌ ±0 

Results for commit 47a94d0. ± Comparison against base commit 5b8dce7.

♻️ This comment has been updated with latest results.

jo0oy
jo0oy approved these changes Dec 14, 2023
View reviewed changes
Copy link
Contributor

@jo0oy jo0oy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

리팩토링 수고하셨습니다~🙂

@JeongUijeong JeongUijeong merged commit 5474d98 into develop Dec 14, 2023
3 checks passed
@JeongUijeong JeongUijeong deleted the feature/favorite-refactor branch December 15, 2023 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wocjf0513 wocjf0513 wocjf0513 approved these changes

@jo0oy jo0oy jo0oy approved these changes

Assignees

@JeongUijeong JeongUijeong

Labels
🚧refactoring 리팩토링
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JeongUijeong @jo0oy @wocjf0513