Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: 예약 도메인 리팩토링 #134

Merged
merged 16 commits into from
Dec 15, 2023
Merged

refactor: 예약 도메인 리팩토링 #134

merged 16 commits into from
Dec 15, 2023

Conversation

jo0oy
Copy link
Contributor

@jo0oy jo0oy commented Dec 15, 2023

💡 Motivation

  • 예약 도메인을 전체적으로 리팩토링 합니다.

📌 Changes

  • 예약 도메인 요청 Request DTO 유효성 검증 제한 값 및 메세지 상수화 (상수 클래스 추가)
  • 불필요한 로그 제거
  • 예약 도메인 유닛 테스트 리팩토링
    • Product, Room 엔티티 테스트 데이터를 생성하는 부분을 메서드로 뺌

🫱🏻‍🫲🏻 To Reviewers

  • 멘토님의 코드 리뷰를 기반으로 리팩토링을 진행했습니다!

jo0oy added 15 commits December 14, 2023 23:52
@jo0oy
refactor: 예약 유효성 검증 조건 및 메세지 상수 클래스 추가
e257fe8
@jo0oy
refactor: 예약 도메인 Request DTO 유효성 검증 조건 상수화한 것 적용
4372274
@jo0oy
remove: 예약 도메인 불필요한 Exception 삭제
fbe654d
@jo0oy
refactor: Reservation 엔티티 @builder 선언한 생성자 접근권한자 private 변경
d1e2881
@jo0oy
move: ReservationMapper 클래스 이동
2e05a70 
- domain/reservation/util/mapper 로 이동
@jo0oy
move: RoomNotFoundException 클래스 Room 도메인 exception 패키지로 이동
a2dda91
@jo0oy
feat: RoomService에 개별 엔티티 조회 서비스 로직 getRoomById 메서드 추가
d97c251
@jo0oy
refactor: 불필요한 debug 로그 제거
9d87029
@jo0oy
refactor: 전체 예약 내역 조회 API 응답 타입 와일드카드에서 정확한 Response 클래스 타입 명시
2321824
@jo0oy
refactor: 페이징 디폴트 요청값 상수화
6455cde
@jo0oy
refactor: ReservationService에서 RoomService.getRoomById(예외 처리 포함)로 Roo…
de66b63 
…m 엔티티 조회하도록 수정
@jo0oy
test: ReservationServiceTest Product, Room Test Data 생성 메서드 추출해서 구현
9dd928b
@jo0oy
test: GetReservationListServiceTest Product, Room, ReservationProduct…
bb3f67f 
… Test Data 생성 메서드 추출 리팩토링
@jo0oy
Merge branch 'develop' into feature/reservation-refactoring
d85dc69
@jo0oy
move: util 패키지 하위에 생성했던 constant 패키지 reservation 도메인 패키지 하위로 이동
017c083
@jo0oy jo0oy added 🚧refactoring 리팩토링 ✅Test test 관련 labels Dec 15, 2023
@jo0oy jo0oy self-assigned this Dec 15, 2023
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 15, 2023 •
edited
Loading

Test Results

105 tests  ±0   105 ✔️ ±0   5s ⏱️ ±0s
  62 suites ±0       0 💤 ±0 
  62 files   ±0       0 ❌ ±0 

Results for commit c9e45b8. ± Comparison against base commit 5474d98.

♻️ This comment has been updated with latest results.

JeongUijeong
JeongUijeong approved these changes Dec 15, 2023
View reviewed changes
Copy link
Contributor

@JeongUijeong JeongUijeong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨어요!! 👍🏻👍🏻

@jo0oy jo0oy merged commit 2c16c98 into develop Dec 15, 2023
3 checks passed
@jo0oy jo0oy deleted the feature/reservation-refactoring branch December 15, 2023 04:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JeongUijeong JeongUijeong JeongUijeong approved these changes

@wocjf0513 wocjf0513 Awaiting requested review from wocjf0513

Assignees

@jo0oy jo0oy

Labels
🚧refactoring 리팩토링 ✅Test test 관련
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jo0oy @JeongUijeong