Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: 예약 상품/객실 도메인 리팩토링 #135

Merged
merged 8 commits into from
Dec 15, 2023
Merged

refactor: 예약 상품/객실 도메인 리팩토링 #135

merged 8 commits into from
Dec 15, 2023

Conversation

jo0oy
Copy link
Contributor

@jo0oy jo0oy commented Dec 15, 2023

💡 Motivation

  • ReservationProduct와 Room 도메인을 전체적으로 리팩토링합니다.

📌 Changes

  • 불필요한 로그 제거
  • 요청 Request DTO에 유효성 검증 조건 및 메세지 상수화 (상수 클래스 추가)

🫱🏻‍🫲🏻 To Reviewers

  • 예약 상품/객실 도메인 리팩토링을 진행했습니다!

jo0oy added 8 commits December 15, 2023 01:55
@jo0oy
refactor: ReservationProduct 엔티티 @builder 설정된 생성자 접근권한자 private으로 변경
352734e
@jo0oy
refactor: ReservationProduct 도메인에 불필요한 로그 제거
052cc55
@jo0oy
refactor: ReservationProduct 요청값 유효성 검증 패턴, 메세지 등 상수화 -> 상수 클래스 추가
f39296d
@jo0oy
refactor: Room 도메인 불필요한 로그 제거
bbe02f3
@jo0oy
refactor: 모든 Room 도메인 엔티티 @builder 설정된 생성자 private 변경
7663512
@jo0oy
refactor: Room 도메인 Request 유효성 검증 관련 조건들 상수화 -> 상수 클래스 추가
8fcc93a
@jo0oy
fix: 유효성 검증 상수화 했던 것 Wrapper 타입으로 인해 build 에러 -> 원시 타입으로 수정
e6b5c82
@jo0oy
Merge branch 'develop' into feature/reservationproduct-room-refactoring
8f71aba 
# Conflicts:
#	src/main/java/com/fc/shimpyo_be/domain/reservationproduct/dto/request/ReservationProductRequestDto.java
@jo0oy jo0oy added 🚧refactoring 리팩토링 ✅Test test 관련 labels Dec 15, 2023
@jo0oy jo0oy self-assigned this Dec 15, 2023
@github-actions GitHub Actions
Copy link

Test Results

105 tests  ±0   105 ✔️ ±0   5s ⏱️ ±0s
  62 suites ±0       0 💤 ±0 
  62 files   ±0       0 ❌ ±0 

Results for commit 8f71aba. ± Comparison against base commit 2c16c98.

JeongUijeong
JeongUijeong approved these changes Dec 15, 2023
View reviewed changes
Copy link
Contributor

@JeongUijeong JeongUijeong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다!

@jo0oy jo0oy merged commit 478cbde into develop Dec 15, 2023
3 checks passed
@jo0oy jo0oy deleted the feature/reservationproduct-room-refactoring branch December 15, 2023 05:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JeongUijeong JeongUijeong JeongUijeong approved these changes

@wocjf0513 wocjf0513 Awaiting requested review from wocjf0513

Assignees

@jo0oy jo0oy

Labels
🚧refactoring 리팩토링 ✅Test test 관련
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jo0oy @JeongUijeong