Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Product, Room, Cart 도메인에 대한 Refactoring #138

Closed
wants to merge 8 commits into from
Closed

refactor: Product, Room, Cart 도메인에 대한 Refactoring #138

wants to merge 8 commits into from

Conversation

wocjf0513
Copy link
Contributor

💡 Motivation

  • 세 도메인에 대한 리팩토링하고자 합니다.

📌 Changes

  • transaction (readOnly=true)를 써서, 읽기만했을때의 성능을 높이고자 합니다.
  • MemberRepository.getById -> MemberService.getMemberById (유효성 검사를 포함하는)

🫱🏻‍🫲🏻 To Reviewers

  • 리팩토링 했어요. 하나의 브랜치에 묶어서 했습니다.. 죄송요

@wocjf0513 wocjf0513 added 🚧refactoring 리팩토링 ✅Test test 관련 labels Dec 15, 2023
@wocjf0513 wocjf0513 self-assigned this Dec 15, 2023
@wocjf0513 wocjf0513 changed the base branch from main to develop December 15, 2023 07:46
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 15, 2023 •
edited
Loading

Test Results

105 tests  ±0   103 ✔️  - 2   5s ⏱️ ±0s
  62 suites ±0       0 💤 ±0 
  62 files   ±0       2 ❌ +2 

For more details on these failures, see this check.

Results for commit 84bf1f7. ± Comparison against base commit 3bbd461.

♻️ This comment has been updated with latest results.

@wocjf0513 wocjf0513 closed this Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jo0oy jo0oy Awaiting requested review from jo0oy

@JeongUijeong JeongUijeong Awaiting requested review from JeongUijeong

Assignees

@wocjf0513 wocjf0513

Labels
🚧refactoring 리팩토링 ✅Test test 관련
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@wocjf0513