Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: product - room - cart 내 log.debug 삭제 및 접근 제어자 수정, transaction(readOnly=true)를 통해 성능 향상 #139

Merged
merged 1 commit into from
Dec 15, 2023
Merged

refactor: product - room - cart 내 log.debug 삭제 및 접근 제어자 수정, transaction(readOnly=true)를 통해 성능 향상 #139

merged 1 commit into from
Dec 15, 2023

Conversation

wocjf0513
Copy link
Contributor

💡 Motivation

  • 기능 완성을 마치고, 리팩토링하고자 합니다. (협업자와 정한 리팩토링 Convetion을 바탕으로)

📌 Changes

  • log.debug 삭제
  • 접근 제어자 수정
  • transaction(readOnly=true) | transaction 분리 사용

🫱🏻‍🫲🏻 To Reviewers

  • 마지막 PR!!

@wocjf0513 wocjf0513 added the 🚧refactoring 리팩토링 label Dec 15, 2023
@wocjf0513 wocjf0513 self-assigned this Dec 15, 2023
@github-actions GitHub Actions
Copy link

Test Results

105 tests  ±0   105 ✔️ ±0   5s ⏱️ ±0s
  62 suites ±0       0 💤 ±0 
  62 files   ±0       0 ❌ ±0 

Results for commit 6843e96. ± Comparison against base commit 3bbd461.

jo0oy
jo0oy approved these changes Dec 15, 2023
View reviewed changes
Copy link
Contributor

@jo0oy jo0oy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고했습니다!

@wocjf0513 wocjf0513 merged commit cc302eb into develop Dec 15, 2023
3 checks passed
@wocjf0513 wocjf0513 deleted the refactor/product branch December 15, 2023 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jo0oy jo0oy jo0oy approved these changes

@JeongUijeong JeongUijeong Awaiting requested review from JeongUijeong

Assignees

@wocjf0513 wocjf0513

Labels
🚧refactoring 리팩토링
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wocjf0513 @jo0oy