Shiphawk 0 8 stable #4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was pluralized in the README, but it looks like it won't work with the s in there. This updates the README to show the working method name correct method name, remove 'netsuite'
This was done to keep Classification consistent with Location and Department segments
add parent to custom record
The Invoice object has an amount property in netsuite that can be returned in transaction searches. It should be available here too.
* Specify the `NoMethodError` to keep RSpec happy and to ensure that other bugs don't sneak by as a passing test * Upgrade single instance of `should` syntax to `expect`
It’s surprising to not be able to, in a rails console, increase the verbosity of the gem’s logging without needing to: 1. Tweak an ENV variable or otherwise change an initializer 2. Directly set `Configuration#attributes` Aka, I would expect the following to work, but it does not. ``` app:staging> NetSuite::Configuration.log_level => :info app:staging> NetSuite::Configuration.log_level = :debug => :debug app:staging> NetSuite::Configuration.log_level => :info ``` Seems like the only way to increase the verbosity is to directly set the appropriate attribute: ``` gravity:staging> NetSuite::Configuration.attributes[:log_level] => :info gravity:staging> NetSuite::Configuration.attributes[:log_level] = :debug => :debug gravity:staging> NetSuite::Configuration.log_level => :debug ``` Moreover, this seems inconsistent with other configuration, for example `Configuration#logger` and `#logger=`
* See 8fc2f2b for motivation * Always set `attributes[:log_level]` when `log_level=` is called * Support `log_level(value)` syntax via a short-circuit, similar to what's done in `#log(path)` and `#silent(value)`
Search seemed to break on versions greater than 2.11
[#13198] Updated exceptions to retry list
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.