Build with ROOT 6.32 without Pythia6 support, building TPythia6 libraries separately #102
Conversation
| TPythia6: | ||
| version: "main" | ||
| tag: "main" |
There was a problem hiding this comment.
This should be in the recipe, not overridden here.
| @@ -40,7 +41,8 @@ incremental_recipe: | | |||
| ${PHOTOSPP_VERSION:+PHOTOSPP/$PHOTOSPP_VERSION-$PHOTOSPP_REVISION} \\ | |||
| ${EVTGEN_VERSION:+EvtGen/$EVTGEN_VERSION-$EVTGEN_REVISION} \\ | |||
| ${FAIRROOT_VERSION:+FairRoot/$FAIRROOT_VERSION-$FAIRROOT_REVISION} \\ | |||
| ${GENFIT_VERSION:+GenFit/$GENFIT_VERSION-$GENFIT_REVISION} | |||
| ${GENFIT_VERSION:+GenFit/$GENFIT_VERSION-$GENFIT_REVISION} \\ | |||
| @@ -111,6 +114,7 @@ cmake $SOURCEDIR \ | |||
| ${CMAKE_VERBOSE_MAKEFILE:+-DCMAKE_VERBOSE_MAKEFILE=ON} \ | |||
| ${BOOST_ROOT:+-DBOOST_ROOT=$BOOST_ROOT} \ | |||
| ${GENFIT:+-Dgenfit2_ROOT=$GENFIT} \ | |||
| -DTPYTHIA6_INCLUDE_DIR=$TPYTHIA6_ROOT/inc \ | |||
There was a problem hiding this comment.
Double quote to prevent globbing and word splitting. [SC2086]
| @@ -139,7 +143,8 @@ module load BASE/1.0 | |||
| ${PHOTOSPP_VERSION:+PHOTOSPP/$PHOTOSPP_VERSION-$PHOTOSPP_REVISION} \\ | |||
| ${EVTGEN_VERSION:+EvtGen/$EVTGEN_VERSION-$EVTGEN_REVISION} \\ | |||
| ${FAIRROOT_VERSION:+FairRoot/$FAIRROOT_VERSION-$FAIRROOT_REVISION} \\ | |||
| ${GENFIT_VERSION:+GenFit/$GENFIT_VERSION-$GENFIT_REVISION} | |||
| ${GENFIT_VERSION:+GenFit/$GENFIT_VERSION-$GENFIT_REVISION} \\ | |||
There was a problem hiding this comment.
Does this also enable pythia8 in GENIE?
| --- | ||
| #!/bin/bash -e | ||
| cmake "$SOURCEDIR" \ | ||
| -DPYTHIA6_ROOT=${PYTHIA6_ROOT} \ |
There was a problem hiding this comment.
Double quote to prevent globbing and word splitting. [SC2086]
| -DPYTHIA6_ROOT=${PYTHIA6_ROOT} \ | ||
|
|
||
| make | ||
| cp -r $SOURCEDIR/inc $INSTALLROOT/inc |
There was a problem hiding this comment.
Double quote to prevent globbing and word splitting. [SC2086]
|
|
||
| make | ||
| cp -r $SOURCEDIR/inc $INSTALLROOT/inc | ||
| cp *.so $INSTALLROOT/ |
There was a problem hiding this comment.
Use ./*glob* or -- *glob* so names with dashes won't become options. [SC2035]
Maybe all these copies should by handled by CMake's install step?
| MODULEFILE="$MODULEDIR/$PKGNAME" | ||
| mkdir -p "$MODULEDIR" | ||
| cat > "$MODULEFILE" <<EoF | ||
| #%Module1.0 |
There was a problem hiding this comment.
Modulefile created manually here; consider using alibuild-generate-module [ali:consider-a-g-m]
|
Changelog entry missing |
Dear all,
From 6.32 ROOT will not support Pythia6 anymore, therefore they remove the TPythia6 libraries.
We currently still use them for the Cascade and MuonDIS production. Until an upgrade to Pythia8 or other alternatives is completed, we can still use ROOT 6.32 by building ourselves the TPythia6 libraries.
This is to be considered a temporary solution, since we also need to move from Pythia6 ourselves.
List of changes:
Please let me know your comment or suggestions to improve this pull request
I am now opening a related pull request to the changes in the FairShip code
Best Regards,
Antonio