fix possible infinite loop while parsing for broken replays (#52)

Shiqan · Mar 9, 2024 · 81138ec · 81138ec
1 parent c322d58
commit 81138ec
Showing 1 changed file with 7 additions and 0 deletions.
diff --git a/src/Unreal.Core/ReplayReader.cs b/src/Unreal.Core/ReplayReader.cs
@@ -317,6 +317,13 @@ public virtual void ReadReplayChunks(FArchive archive)
             var chunkSize = archive.ReadInt32();
             var offset = archive.Position;
 
+            if (chunkSize <= 0 || (long) chunkSize + offset > int.MaxValue)
+            {
+                _logger?.LogError("Invalid chunk size ({chunkSize} for chunk {chunkType}) at offset {offset}. Stopping the parsing...", chunkSize, chunkType, archive.Position);
+                archive.SetError();
+                return;
+            }
+
             if (chunkType == ReplayChunkType.ReplayData && _parseMode > ParseMode.EventsOnly)
             {
                 ReadReplayData(archive, chunkSize);