You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Thanks for the great work with this library. I have a feature request though.
Currently, in order to find the other files in the project, you add them to the path manually. This is not a good practice in general and leads to several problems. One of them is I am not able to get any Language Server completions since LSP can't recognize the path additions. This makes navigating the code much harder. Also, with this hardcoded addition, the library cannot be installed and used with other libraries. For example, if I had a different mapper than NDT, i can't use it with the existing code easily without making additions to your library as well which would make it difficult to keep up with the newer Github releases.
My suggestion is to package the project using pyproject.toml so that library users can install this to their machine and get full LSP support and flexibility in adding additional stuff.
One more suggestion is also use a linter and formatter such as ruff. It would greatly help in organizing the imports, enforce good code and provide better readibility.
If you are open to it, I can add pyproject support with tooling.
The text was updated successfully, but these errors were encountered:
Hi, @egeKeyvan. Thank you for suggesting the good improvement idea!!
This is the first opened issue for my project, I'm so glad!!
I want to ask you to add pyproject support and send me a pull request, but a document about how to contribute to this project has not been prepared well yet. So, I will add by myself this time.
I will let you know here after I could add.
Thank you for your suggestion again!!
Great, thanks for the effort on improving the library! Please let me know if there is anything you need help with. Also, please consider having a publication list for referencing in case this work is useful in academic context
Thanks for the great work with this library. I have a feature request though.
Currently, in order to find the other files in the project, you add them to the path manually. This is not a good practice in general and leads to several problems. One of them is I am not able to get any Language Server completions since LSP can't recognize the path additions. This makes navigating the code much harder. Also, with this hardcoded addition, the library cannot be installed and used with other libraries. For example, if I had a different mapper than NDT, i can't use it with the existing code easily without making additions to your library as well which would make it difficult to keep up with the newer Github releases.
My suggestion is to package the project using pyproject.toml so that library users can install this to their machine and get full LSP support and flexibility in adding additional stuff.
One more suggestion is also use a linter and formatter such as ruff. It would greatly help in organizing the imports, enforce good code and provide better readibility.
If you are open to it, I can add pyproject support with tooling.
The text was updated successfully, but these errors were encountered: