Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get tests to pass locally #3

Merged
merged 2 commits into from
Jan 31, 2025
Merged

Get tests to pass locally #3

merged 2 commits into from
Jan 31, 2025

Conversation

shioyama
Copy link
Member

@shioyama shioyama commented Jan 30, 2025

This gem is currently pretty hard to use locally since the test setup has gone stale. I made some changes that allow me to run the tests with bundle exec rake test:

# Running:

..................................

Fabulous run in 0.074798s, 454.5576 runs/s, 1871.7078 assertions/s.

34 runs, 140 assertions, 0 failures, 0 errors, 0 skips

@shioyama shioyama changed the title Shioyama/cleanup Get tests to pass locally Jan 30, 2025
.ruby-version Outdated
@@ -0,0 +1 @@
3.4.0-preview2

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's do 3.4.1 as preview2 must be our internal version which is not helpful for an open-source gem

@shioyama shioyama merged commit 7cb42bf into master Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants