Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change local CLI environment fqdn options to point to local dev URLs #4845

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jamieguerrero
Copy link
Contributor

@jamieguerrero jamieguerrero commented Nov 12, 2024

WHY are these changes introduced?

To get local CLI working with local dev on shopify

WHAT is this pull request doing?

Changed the FQDN configs for the local SHOPIFY_SERVICE_ENV option

How to test your changes?

To try this:

Run both identity and business-platform with:

dev up identity
and
dev up business-platform

Check out this branch in your local dev

Confirm that you can create an app and link it to your local dev env
bin/local p run shopify app config link --path=../your-app-path

Post-release steps

Measuring impact

How do we know this change was effective? Please choose one:

  • n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
  • Existing analytics will cater for this addition
  • PR includes analytics changes to measure impact

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes

@jamieguerrero jamieguerrero requested a review from a team as a code owner November 12, 2024 18:46
Copy link
Contributor

@shauns shauns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you pull the latest from main in? I think most of this is already done since adding DevServer. The local script wasnt touched though.

@shauns reviewed this PR from Slack with Graphite

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants