Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test #4859

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

test #4859

wants to merge 4 commits into from

Conversation

jamesmengo
Copy link
Contributor

WHY are these changes introduced?

Fixes #0000

WHAT is this pull request doing?

How to test your changes?

Post-release steps

Measuring impact

How do we know this change was effective? Please choose one:

  • n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
  • Existing analytics will cater for this addition
  • PR includes analytics changes to measure impact

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes

Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link
Contributor Author

/snapit

Copy link
Contributor

🫰✨ Thanks @jamesmengo! Your snapshot has been published to npm.

Test the snapshot by intalling your package globally:

pnpm i -g @shopify/[email protected]

After installing, validate the version by running just shopify in your terminal
If the versions don't match, you might have multiple global instances installed.
Use which shopify to find out which one you are running and uninstall it.

Copy link
Contributor

github-actions bot commented Nov 14, 2024

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements 74.35% 8517/11455
🟡 Branches 70.14% 4155/5924
🟡 Functions 73.87% 2239/3031
🟡 Lines 74.88% 8055/10757
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🟢
... / ConcurrentOutput.tsx
98.36% (-1.64% 🔻)
88% (-4% 🔻)
100%
98.33% (-1.67% 🔻)

Test suite run success

1942 tests passing in 884 suites.

Report generated by 🧪jest coverage report action from 6e7b2de

Copy link
Contributor Author

/snapit

Copy link
Contributor

🫰✨ Thanks @jamesmengo! Your snapshot has been published to npm.

Test the snapshot by intalling your package globally:

pnpm i -g @shopify/[email protected]

After installing, validate the version by running just shopify in your terminal
If the versions don't match, you might have multiple global instances installed.
Use which shopify to find out which one you are running and uninstall it.

Copy link
Contributor Author

/snapit

Copy link
Contributor

🫰✨ Thanks @jamesmengo! Your snapshot has been published to npm.

Test the snapshot by intalling your package globally:

pnpm i -g @shopify/[email protected]

After installing, validate the version by running just shopify in your terminal
If the versions don't match, you might have multiple global instances installed.
Use which shopify to find out which one you are running and uninstall it.

@jeffreyguenther
Copy link

@jamesmengo don't have a better way to reach out. Thanks for you all you're doing on the the public themes API! 🙌🏻

Copy link
Contributor Author

jamesmengo commented Nov 14, 2024

@jamesmengo don't have a better way to reach out. Thanks for you all you're doing on the the public themes API! 🙌🏻

@jeffreyguenther
Thank YOU for your feedback and for helping us improve our service! Apologies for the delays - I've been out sick and have some upcoming PTO, but rest assured that this is something I'm personally invested in fixing :)

@jamesmengo
Copy link
Contributor Author

@jeffreyguenther

The JSDoc is not getting re-exported from the CLI package atm, so if you need a reference of what the functions accept, you can refer here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants