Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Shopify/theme-tools packages #4886

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

charlespwd
Copy link
Contributor

@charlespwd charlespwd commented Nov 19, 2024

Bump theme tools dependencies

How to test your changes?

cli-tophat.mp4

theme check

pnpm build
pnpm shopify:run theme check --path=../dawn

language server

  1. Build the project
pnpm build
  1. Create a globally accessible liquid-language-server command. Mine is in $HOME/bin

.zshrc

export PATH="$HOME/bin:$PATH"

$HOME/bin/liquid-language-server

#!/usr/bin/env bash
cd $HOME/src/github.com/Shopify/cli
pnpm run --silent shopify:run theme language-server
  1. install neovim
  2. setup https://github.com/neoclide/coc.nvim & https://github.com/tpope/vim-liquid
  3. :CocConfig
  4. Add the following config
{
  "languageserver": {
    "theme-check": {
      "command": "liquid-language-server",
      "trace.server": "verbose",
      "filetypes": ["liquid", "liquid.html"],
      "rootPatterns": [".theme-check.yml", "snippets/*"],
      "settings": {
        "themeCheck": {
          "checkOnSave": true,
          "checkOnEnter": true,
          "checkOnChange": false
        }
      }
    }
  },
}

Go to a liquid repo, fire up the editor and see completions/linting/etc running fine.

@charlespwd charlespwd requested review from a team as code owners November 19, 2024 19:52
@charlespwd charlespwd force-pushed the bump/theme-tools-2024-11-19 branch 3 times, most recently from 7dbd5b2 to 82e27c4 Compare November 19, 2024 21:02
Copy link
Contributor

github-actions bot commented Nov 19, 2024

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
74.51% (-0.02% 🔻)
8541/11463
🟡 Branches
70.34% (-0.06% 🔻)
4171/5930
🟡 Functions
74.01% (+0.09% 🔼)
2241/3028
🟡 Lines
75.05% (+0% 🔼)
8078/10764
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🟢
... / extension-instance.ts
85.26% (-1.28% 🔻)
80.53% (-0.88% 🔻)
92%
86.81% (-1.39% 🔻)
🟢
... / extension.ts
85.71% (-14.29% 🔻)
0% (-100% 🔻)
75% (-25% 🔻)
85.71% (-14.29% 🔻)
🔴
... / dev-session.ts
4.21% (-0.19% 🔻)
0%
4.35% (-0.2% 🔻)
4.76% (-0.12% 🔻)

Test suite run success

1946 tests passing in 885 suites.

Report generated by 🧪jest coverage report action from 81de74e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant