-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unused setupExtensionWatcher #4904
Merged
Merged
+0
−504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 21, 2024
This stack of pull requests is managed by Graphite. Learn more about stacking. |
3 tasks
Unused dependencies (1)
Unused devDependencies (1)
Unused types (1)
|
We detected some changes at packages/*/src and there are no updates in the .changeset. |
Coverage report
Show files with reduced coverage 🔻
Test suite run success1949 tests passing in 888 suites. Report generated by 🧪jest coverage report action from 6d55815 |
shauns
approved these changes
Nov 22, 2024
isaacroldan
force-pushed
the
11-21-remove_unused_setupextensionwatcher
branch
3 times, most recently
from
November 22, 2024 17:02
ca0d805
to
2d51405
Compare
isaacroldan
force-pushed
the
11-20-use_appwatcher_to_watch_for_function_changes_in_function_replay
branch
from
November 25, 2024 10:53
63efc98
to
9ecc934
Compare
isaacroldan
force-pushed
the
11-21-remove_unused_setupextensionwatcher
branch
from
November 25, 2024 10:53
2d51405
to
d4e4c5f
Compare
isaacroldan
changed the base branch from
11-20-use_appwatcher_to_watch_for_function_changes_in_function_replay
to
graphite-base/4904
November 25, 2024 11:01
isaacroldan
force-pushed
the
11-21-remove_unused_setupextensionwatcher
branch
from
November 25, 2024 11:02
d4e4c5f
to
6d55815
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Removes the extension bundler watcher and its tests as they are no longer needed after migrating to the new AppWatcher flow.
WHAT is this pull request doing?
Deletes
bundler.ts
andbundler.test.ts
files which were responsible for watching and rebuilding extensions during development. This functionality has been replaced by the new AppWatcher flow.How to test your changes?
Nothing to test, this PR just removes dead code.
Measuring impact
Checklist