Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused setupExtensionWatcher #4904

Merged
merged 1 commit into from
Nov 25, 2024

Conversation

isaacroldan
Copy link
Contributor

@isaacroldan isaacroldan commented Nov 21, 2024

WHY are these changes introduced?

Removes the extension bundler watcher and its tests as they are no longer needed after migrating to the new AppWatcher flow.

WHAT is this pull request doing?

Deletes bundler.ts and bundler.test.ts files which were responsible for watching and rebuilding extensions during development. This functionality has been replaced by the new AppWatcher flow.

How to test your changes?

Nothing to test, this PR just removes dead code.

Measuring impact

  • n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes

Copy link
Contributor

Unused dependencies (1)

Filename dependencies
packages/app/package.json micromatch

Unused devDependencies (1)

Filename devDependencies
packages/app/package.json @types/micromatch

Unused types (1)

Filename types
packages/app/src/cli/services/build/extension.ts BuildFunctionExtensionOptions

@isaacroldan isaacroldan marked this pull request as ready for review November 21, 2024 16:01
@isaacroldan isaacroldan requested a review from a team as a code owner November 21, 2024 16:01
Copy link
Contributor

We detected some changes at packages/*/src and there are no updates in the .changeset.
If the changes are user-facing, run "pnpm changeset add" to track your changes and include them in the next release CHANGELOG.

Copy link
Contributor

github-actions bot commented Nov 21, 2024

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
75.29% (-0.12% 🔻)
8632/11465
🟡 Branches
70.69% (-0.09% 🔻)
4208/5953
🟡 Functions
74.9% (-0.08% 🔻)
2265/3024
🟡 Lines
75.85% (-0.11% 🔻)
8164/10763
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🟢
... / extension-instance.ts
80.5% (-4.75% 🔻)
76.52% (-4.01% 🔻)
90.2% (-1.8% 🔻)
81.51% (-5.3% 🔻)
🟢
... / dev-session.ts
85.96% (-0.52% 🔻)
68.33% (+2.26% 🔼)
91.67% (+0.76% 🔼)
92.93% (+0.22% 🔼)
🟢
... / useFunctionWatcher.ts
80%
62.5% (-4.17% 🔻)
63.16%
84% (+1.02% 🔼)

Test suite run success

1949 tests passing in 888 suites.

Report generated by 🧪jest coverage report action from 6d55815

@isaacroldan isaacroldan force-pushed the 11-21-remove_unused_setupextensionwatcher branch 3 times, most recently from ca0d805 to 2d51405 Compare November 22, 2024 17:02
@isaacroldan isaacroldan force-pushed the 11-20-use_appwatcher_to_watch_for_function_changes_in_function_replay branch from 63efc98 to 9ecc934 Compare November 25, 2024 10:53
@isaacroldan isaacroldan force-pushed the 11-21-remove_unused_setupextensionwatcher branch from 2d51405 to d4e4c5f Compare November 25, 2024 10:53
Copy link
Contributor Author

isaacroldan commented Nov 25, 2024

Merge activity

  • Nov 25, 6:00 AM EST: A user started a stack merge that includes this pull request via Graphite.
  • Nov 25, 6:03 AM EST: Graphite rebased this pull request as part of a merge.
  • Nov 25, 6:09 AM EST: A user merged this pull request with Graphite.

@isaacroldan isaacroldan changed the base branch from 11-20-use_appwatcher_to_watch_for_function_changes_in_function_replay to graphite-base/4904 November 25, 2024 11:01
@isaacroldan isaacroldan changed the base branch from graphite-base/4904 to main November 25, 2024 11:01
@isaacroldan isaacroldan force-pushed the 11-21-remove_unused_setupextensionwatcher branch from d4e4c5f to 6d55815 Compare November 25, 2024 11:02
@isaacroldan isaacroldan merged commit 50dba6a into main Nov 25, 2024
25 of 27 checks passed
@isaacroldan isaacroldan deleted the 11-21-remove_unused_setupextensionwatcher branch November 25, 2024 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants