Bulk Quick Add: Clicking "-" takes you back to 0

[sofiamatulis]

PR Summary:

Clicking on - takes you back to 0 on live cart. This shouldn't affect regular add to cart

Why are these changes introduced?

Fixes #issue.

What approach did you take?

Visual impact on existing themes

The buyer will be able to remove items from cart in live cart by using -

Testing steps/scenarios

• Test cart (with and without vol pricing, qty rules) updating items in cart
• Test cart drawer updating items in cart (with and without vol pricing, qty rules)
• Test adding to cart from PDP, feat product (regular add to cart - this shouldnt be affected)
• Test Quick Order List (with and without vol pricing, qty rules) updating items in cart
• Test Quick Add bulk in the collection page (with and without vol pricing, qty rules) updating items in cart

Demo links

• Editor

Checklist

• Added PR summary for release notes
• Requested review from UX (Only for changes that are affecting the experience or perceivable visual details)
• Created a ticket for the help.shopify.com documentation team about updates to theme settings. (Internal-only task)
• Followed theme code principles
• Linted with Theme Check
• Tested on mobile
• Tested on multiple browsers
• Tested for accessibility

[scottgmeadows]

Something is broken in this PR adding to cart when there are quantity rules. Wasn't able to test - taking you back to 0.

Here's the problem I experienced.

Repro steps:

1. View a product with volume pricing and quantity rules as a b2b customer (eg: something with increments of 5, and a min of 10)
2. Click plus button
3. You'll get an error that says product has a min of 10 - but in dawn production we automatically infer the first valid value.
4. Also a something is wrong error at the bottom.

[sofiamatulis]

Something is broken in this PR adding to cart when there are quantity rules. Wasn't able to test - taking you back to 0.

Here's the problem I experienced.

Repro steps:

1. View a product with volume pricing and quantity rules as a b2b customer (eg: something with increments of 5, and a min of 10)
2. Click plus button
3. You'll get an error that says product has a min of 10 - but in dawn production we automatically infer the first valid value.
4. Also a something is wrong error at the bottom.

@scottgmeadows Good catch 👍 this was happening when we had a stepcount lower than the min. This should be fixed now

[eugenekasimov]

I did the first pass and everything looks good except that the PDP was a bit effected in my opinion. As far as I understnd you shouldn't be able to click on "-" on PDP to go to 0. I'm going to test more.

[eugenekasimov]

Works as expected! 🚀

[andrewetchen]

• Test cart drawer (with and without vol pricing, qty rules) updating items in cart
• Test drawer updating items in cart (with and without vol pricing, qty rules)
• Test adding to cart from PDP, feat product (regular add to cart - this shouldnt be affected)
• Test Quick Order List (with and without vol pricing, qty rules) updating items in cart
• Test Quick Add bulk in the collection page (with and without vol pricing, qty rules) updating items in cart

I tested everything above and it works as expected.

I did some more testing and noticed that when Enable quick add button is checked within the featured collection section on the homepage or PDP, it doesn't work (video). I also checked the editor link from #3217 and the same thing occurs. I'm assuming this is intentional and that it'll be taken care of in another PR? 🤔

[sofiamatulis]

I did some more testing and noticed that when Enable quick add button is checked within the featured collection section on the homepage or PDP, it doesn't work (video). I also checked the editor link from #3217 and the same thing occurs. I'm assuming this is intentional and that it'll be taken care of in another PR? 🤔

Yes, this is not part of this PR and will be taken care of when we introduce the new quick add to the remaining portions of the theme - issues are tracked here https://github.com/orgs/Shopify/projects/6397/views/26?pane=issue&itemId=50891026

[scottgmeadows]

Tested all the scenarios and LGTM :)