fix: trigger onViewableItemsChanged when calling MasonryFlashList's recomputeViewableItems after data changed #1433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ecomputeViewableItems after data changed
|
I have signed the CLA! |
2 tasks
|
Hi, @naqvitalha. Can you review my commit, which is very relevant to the last PR #1296 you were involved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am glad to see that @Paduado has added the
recomputeViewableItemsmethod to solve the problem that theonViewableItemsChangedwill not be called after the FlashList's data is updated.But the MasonryFlashList I used in my project did not enjoy this benefit.
So I changed the MasonryFlashList source code to achieve the same effect as FlashList.
Reviewers’ hat-rack 🎩
Screenshots or videos (if needed)
Checklist