-
Notifications
You must be signed in to change notification settings - Fork 222
Conversation
branches: [master] | ||
pull_request: | ||
branches: [master] | ||
on: push |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was previously setup just to run CI on pushes to master, not sure why. It now runs CI on all pushes to this repo.
- name: 💅🏼 Lint | ||
run: | | ||
yarn lint | ||
yarn ci:lint-docs | ||
|
||
node-build: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if there's a way to re-use all of this duplication :/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doesn't seem so - actions/starter-workflows#245.
I stumbled across the needs
field while looking through their docs. Couldn't get it to work properly and it arguably ends up creating more duplication - 89013b8.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
89013b8
to
884056f
Compare
Grr we have a flaky test that got flakier after the switch to GitHub Actions somehow. |
Description
This PR splits up our CI checks into parallel jobs to boost CI times (shaves of a couple mins). This is also helps with CI reporting errors sooner than later since it's parallel.
Before
After