Add isCCW param for addCircle

Shopify · Sep 30, 2024 · 8dd26be · 8dd26be
1 parent 8f016e9
commit 8dd26be
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 4 deletions.
diff --git a/packages/skia/cpp/api/JsiSkPath.h b/packages/skia/cpp/api/JsiSkPath.h
@@ -436,7 +436,11 @@ class JsiSkPath : public JsiSkWrappingSharedPtrHostObject<SkPath> {
     auto x = arguments[0].asNumber();
     auto y = arguments[1].asNumber();
     auto r = arguments[2].asNumber();
-    getObject()->addCircle(x, y, r);
+    auto direction = SkPathDirection::kCW;
+    if (count >= 4 && arguments[3].getBool()) {
+      direction = SkPathDirection::kCCW;
+    }
+    getObject()->addCircle(x, y, r, direction);
     return thisValue.getObject(runtime);
   }
 

diff --git a/packages/skia/src/skia/types/Path/Path.ts b/packages/skia/src/skia/types/Path/Path.ts
@@ -486,7 +486,7 @@ export interface SkPath extends SkJSIInstance<"Path"> {
       @param radius  distance from center to edge      
       @return        reference to SkPath
   */
-  addCircle(x: number, y: number, r: number): SkPath;
+  addCircle(x: number, y: number, r: number, isCCW?: boolean): SkPath;
 
   getLastPt(): { x: number; y: number };
 

diff --git a/packages/skia/src/skia/web/JsiSkPath.ts b/packages/skia/src/skia/web/JsiSkPath.ts
@@ -303,8 +303,8 @@ export class JsiSkPath extends HostObject<Path, "Path"> implements SkPath {
     return this.ref.isVolatile();
   }
 
-  addCircle(x: number, y: number, r: number) {
-    this.ref.addCircle(x, y, r);
+  addCircle(x: number, y: number, r: number, isCCW?: boolean) {
+    this.ref.addCircle(x, y, r, isCCW);
     return this;
   }