Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support build for tvOS #1959

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from
Draft

Support build for tvOS #1959

wants to merge 8 commits into from

Conversation

jhen0409
Copy link

@jhen0409 jhen0409 commented Nov 7, 2023

I was wondering if add Apple TV support would be welcome here. I'm a user of react-native-tvos and building iOS/tvOS app with that.

This PR is adds support build skia libraries for tvOS. I've tested it with my own app and it works fine so far. I'm not sure if it also need add an example based on react-native-tvos or just update the example. I can add it if needed.

@jhen0409
Copy link
Author

jhen0409 commented Nov 7, 2023

I have signed the CLA!

@jhen0409
Copy link
Author

jhen0409 commented Nov 13, 2023

I’ve been created a new package for testing and integrating into my projects.

Also added exampletvos for testing easily:

Screen.Recording.2023-12-09.at.7.32.12.AM.mov

Most of examples are works well, but some problems:

  • Looks like react-native-gesture-handler has some building issues with tvOS even it supported in podspec, so I temporary added a patch for that.
  • Some example like Stickers will cause Exception thrown while executing UI block: *** -[__NSArrayM insertObject:atIndex:]: object cannot be nil, I haven't inspected that deeply so not sure if it's related to RNSkia or not, the rendering looks correct.
  • Some examples not works because Switch (I'm using RN 0.72 in exampletvos)

Currently the example is not ok due to duplicate code, but I’ll keep this until any comment that agree with this PR (Changed to draft).

@jhen0409 jhen0409 marked this pull request as draft November 13, 2023 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant