-
Notifications
You must be signed in to change notification settings - Fork 452
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support build for tvOS #1959
Draft
jhen0409
wants to merge
8
commits into
Shopify:main
Choose a base branch
from
jhen0409:tvos
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Support build for tvOS #1959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I have signed the CLA! |
I’ve been created a new package for testing and integrating into my projects. Also added exampletvos for testing easily: Screen.Recording.2023-12-09.at.7.32.12.AM.movMost of examples are works well, but some problems:
Currently the example is not ok due to duplicate code, but I’ll keep this until any comment that agree with this PR (Changed to draft). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was wondering if add Apple TV support would be welcome here. I'm a user of react-native-tvos and building iOS/tvOS app with that.
This PR is adds support build skia libraries for tvOS. I've tested it with my own app and it works fine so far. I'm not sure if it also need add an example based on react-native-tvos or just update the example. I can add it if needed.