Reload routes when changed #501
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andyw8
force-pushed
the
andyw8/reload-routes-when-changed
branch
from
ff848d9
to
003e017
Compare
andyw8
force-pushed
the
andyw8/reload-routes-when-changed
branch
from
003e017
to
34356a2
Compare
andyw8
force-pushed
the
andyw8/reload-routes-when-changed
branch
from
30a8a50
to
8944ed6
Compare
andyw8
commented
Nov 1, 2024
| private | ||
|
|
||
| def response | ||
| _headers, content = @stdout.string.split("\r\n\r\n") |
There was a problem hiding this comment.
Had to change to handle making multiple requests.
andyw8
commented
Nov 1, 2024
| JSON.parse(content, symbolize_names: true) | ||
| headers, content = @stdout.string.split("\r\n\r\n") | ||
| content_length = headers[/Content-Length: (\d+)/i, 1].to_i | ||
| # binding.break |
There was a problem hiding this comment.
@vinistock I'm trying to figure out what's happening here: If I add the breakpoint, and call @stdout.string = "" each time, it passes. But I call it from the code it fails with not opened for writing (IOError).
andyw8
commented
Nov 1, 2024
| change[:uri].end_with?("db/schema.rb") || change[:uri].end_with?("structure.sql") | ||
| end | ||
| schema = lambda { |change| change[:uri].end_with?("db/schema.rb") || change[:uri].end_with?("structure.sql") } | ||
| routes = lambda { |change| change[:uri].end_with?("routes.rb") || change[:uri].match?("routes/**/*.rb") } |
There was a problem hiding this comment.
Refactored to simplify the conditional.
andyw8
commented
Nov 1, 2024
| @@ -141,7 +144,7 @@ def register_additional_file_watchers(global_state:, outgoing_queue:) | |||
| register_options: Interface::DidChangeWatchedFilesRegistrationOptions.new( | |||
| watchers: [ | |||
| Interface::FileSystemWatcher.new( | |||
| glob_pattern: "**/*structure.sql", | |||
| glob_pattern: "**/*structure.sql,**/*routes.rb,routes/**/*.rb", | |||
There was a problem hiding this comment.
I think this should cover almost any way that people set up the Rails routes, but there is a risk of a false positive if someone is using the term routes for something else in their app.
There was a problem hiding this comment.
🤔 but I wonder if we can ask Rails where all the routes files are...
There was a problem hiding this comment.
Possibly:
dummy(dev)> Rails.application.routes.draw_paths.map(&:to_s)
=>
["/Users/andyw8/.gem/ruby/3.3.0/gems/actionview-8.0.0.beta1/config/routes",
"/Users/andyw8/.gem/ruby/3.3.0/gems/activestorage-8.0.0.beta1/config/routes",
"/Users/andyw8/.gem/ruby/3.3.0/gems/actioncable-8.0.0.beta1/config/routes",
"/Users/andyw8/.gem/ruby/3.3.0/gems/actionmailbox-8.0.0.beta1/config/routes",
"/Users/andyw8/.gem/ruby/3.3.0/gems/actiontext-8.0.0.beta1/config/routes",
"/Users/andyw8/src/github.com/Shopify/ruby-lsp-rails/test/dummy/config/routes",
"/Users/andyw8/src/github.com/Shopify/ruby-lsp-rails/test/dummy/config/routes"]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.