Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add debugger integration test for project with local Bundler settings #2882

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

vinistock
Copy link
Member

@vinistock vinistock commented Nov 19, 2024

Motivation

This PR adds an integration test to verify that we can launch the debugger properly for a project with Bundler settings.

This test fails in versions previous than v0.22.0 because we weren't returning the composed bundle env back to the extension, with the same failure reported in #1767 and #1785.

@vinistock vinistock added the chore Chore task label Nov 19, 2024 — with Graphite App
@vinistock vinistock marked this pull request as ready for review November 19, 2024 19:23
@vinistock vinistock requested a review from a team as a code owner November 19, 2024 19:23
@vinistock vinistock force-pushed the 11-07-merge_composed_bundle_environment_into_ruby_object branch from 0915b82 to 25f00de Compare November 19, 2024 19:24
@vinistock vinistock force-pushed the 11-07-add_debugger_integration_test_for_project_with_local_bundler_settings branch from c046f31 to aefa155 Compare November 19, 2024 19:24
@vinistock vinistock force-pushed the 11-07-merge_composed_bundle_environment_into_ruby_object branch from 25f00de to 2b3512d Compare November 20, 2024 19:41
@vinistock vinistock changed the base branch from 11-07-merge_composed_bundle_environment_into_ruby_object to graphite-base/2882 November 20, 2024 20:08
@vinistock vinistock force-pushed the 11-07-add_debugger_integration_test_for_project_with_local_bundler_settings branch from aefa155 to 5a61541 Compare November 20, 2024 21:22
@vinistock vinistock changed the base branch from graphite-base/2882 to main November 20, 2024 21:23
@vinistock vinistock force-pushed the 11-07-add_debugger_integration_test_for_project_with_local_bundler_settings branch from 5a61541 to 05effda Compare November 21, 2024 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Chore task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant