Make Notification use consistent #2887
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andyw8
added
chore
andyw8
commented
Nov 20, 2024
| @@ -161,6 +169,8 @@ def initialize(id:, method:, params:) | |||
| super(method: method, params: params) | |||
| end | |||
|
|
|||
| private_class_method :new # we want to force the use of the factory methods | |||
There was a problem hiding this comment.
(I'll need to check if any add-ons call this)
andyw8
force-pushed
the
andyw8/make-notification-usage-consistent
branch
from
0c0731c
to
5007406
Compare
andyw8
force-pushed
the
andyw8/make-notification-usage-consistent
branch
from
5007406
to
49bb79e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed while working on the Tapioca LSP.