Limit supported client schemes to file and git #2889
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
With the new AI developments for editors, the LSP receives a lot of unnecessary requests coming from "ghost" schemes. They are usually some sort of resource URI related to the chat or something happening in the background, but it's not actually relevant for the user.
In addition to leading to extra work in the server that is completely unnecessary, it also often confuses users because some of these resources don't send a
textDocument/didOpen
notification before starting to request for other features, which leads to the non existing document error and then people think something is broken, when in reality it's not.Implementation
Let's limit the schemes we handle to
file
andgit
.Automated Tests
Updated existing tests.