Ensure ancient Ruby compatibility in vscode/activation.rb
#3250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ensures if the version is bumped in development, it is also added to the matrix.
We should always test against the minimum Ruby version we support, and it shouldn't be removed without also bumping the `required_ruby_version` in the gemspec.
- Bundler 2.6 requires Ruby 3.1 - Tapioca > 0.14 requires Ruby 3.1 I've changed `BUNDLED WITH` to the latest version in the 2.5 series, which supports Ruby 3.0, and I've removed the version requirement on `tapioca` (and run `bundle update`). Let's see if this passes CI...
This identifies a number of offenses, which have been corrected. Notably, `rubocop-md` treats Markdown code blocks without a language specified as Ruby by default. We could change this behaviour, but it's clearer to explicitly mark the snippets as `txt` when there is no matching language.
Given the purpose of this script is to collect information about the user's Ruby version, we don't know their version yet. Therefore, we must write the most backwards compatible Ruby we can, or else they may get errors when the editor's environment includes an older Ruby version than we expect (e.g. an old system Ruby, in a non-Ruby project).
Given the purpose of this script is to collect information about the user's Ruby version, we don't know their version yet. Therefore, we must write the most backwards compatible Ruby we can, or else they may get errors when the editor's environment includes an older Ruby version than we expect (e.g. an old system Ruby, in a non-Ruby project). Running the script in Ci ensures we are compatible at runtime, not just as a matter of syntax compatibility.
`filter_map` was introduced in Ruby 2.7, but this script may be run by an ancient Ruby version.
How to use the Graphite Merge QueueAdd the label graphite-merge to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures if the version is bumped in development, it is also added
to the matrix.
Motivation
vscode/activation.rbis run by the extension to collect Ruby version information.This means it may run against an unknown Ruby version, which means we can't rely on recent syntax/method support. We want the script to run without error even on these old versions, so that we can correctly detect the Ruby version and detect if we support it.
Implementation
This replaces
filter_mapwith.map { ... }.compact, which ensures the activation script doesn't blow up on old Ruby versions.It also configures CI to check for this to ensure no regressions are introduced.
Automated Tests
Yes, see above ☝️
Before Merging