Implement dup on unbound method #519
Open
+45
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Rails
_read_attribute
is defined on the top level ActiveRecord::Base rather than the subclasses. This results in object shapes not being able to use their cache. By implementingdup
on unbound methods we can give each subclass a uniq iseq and unique inline cache, increasing our shape cache hits.Note: experimental change that must be paired with changes to Active Record to see results.