Update test case for both clients

Shopify · Nov 18, 2024 · 4413e97 · 4413e97
1 parent 3ffa4b0
commit 4413e97
Show file tree

Hide file tree

Showing 2 changed files with 54 additions and 0 deletions.
diff --git a/packages/apps/shopify-api/lib/clients/admin/__tests__/admin_graphql_client.test.ts b/packages/apps/shopify-api/lib/clients/admin/__tests__/admin_graphql_client.test.ts
@@ -127,6 +127,33 @@ describe('GraphQL client', () => {
     }).toMatchMadeHttpRequest();
   });
 
+  it('adapts to private app requests only if isCustomStoreApp', async () => {
+    const shopify = shopifyApi(
+      testConfig({
+        isCustomStoreApp: false,
+        adminApiAccessToken: 'dangit-another-access-token',
+      }),
+    );
+
+    const client = new shopify.clients.Graphql({session});
+    queueMockResponse(JSON.stringify(successResponse));
+
+    await expect(client.request(QUERY)).resolves.toEqual(
+      expect.objectContaining(successResponse),
+    );
+
+    const customHeaders: Record<string, string> = {};
+    customHeaders[ShopifyHeader.AccessToken] = accessToken;
+
+    expect({
+      method: 'POST',
+      domain,
+      path: `/admin/api/${shopify.config.apiVersion}/graphql.json`,
+      data: {query: QUERY},
+      headers: customHeaders,
+    }).toMatchMadeHttpRequest();
+  });
+
   it('fails to instantiate without access token', () => {
     const shopify = shopifyApi(testConfig());
 

diff --git a/packages/apps/shopify-api/lib/clients/admin/__tests__/rest_client.test.ts b/packages/apps/shopify-api/lib/clients/admin/__tests__/rest_client.test.ts
@@ -418,6 +418,33 @@ describe('REST client', () => {
     }).toMatchMadeHttpRequest();
   });
 
+  it('adapts to private app requests only if isCustomStoreApp', async () => {
+    const shopify = shopifyApi(
+      testConfig({
+        isCustomStoreApp: false,
+        adminApiAccessToken: 'test-admin-api-access-token',
+      }),
+    );
+
+    const client = new shopify.clients.Rest({session});
+
+    queueMockResponse(JSON.stringify(successResponse));
+
+    await expect(client.get({path: 'products'})).resolves.toEqual(
+      buildExpectedResponse(successResponse),
+    );
+
+    const customHeaders: Record<string, string> = {};
+    customHeaders[ShopifyHeader.AccessToken] = accessToken;
+
+    expect({
+      method: 'GET',
+      domain,
+      path: `/admin/api/${shopify.config.apiVersion}/products.json`,
+      headers: customHeaders,
+    }).toMatchMadeHttpRequest();
+  });
+
   it('fails to instantiate without access token', () => {
     const shopify = shopifyApi(testConfig());