Treat build_script as optional
#24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 14, 2024
|
Testing:
I'm confident in this fix and stuff is broken without it so gonna merge and ask for forgiveness later. |
|
Thank you Ben! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #23.
We accidentally made build_script required in a combo of c799173 and https://github.com/Shopify/snapit/pull/22/files?w=1 thanks to a misplaced
}- it was added at the end of the file rather than at the end of thecatchblock - thus causing everything to end up inside theif (build_script)block.This PR puts that
}in the right place so that theif (branch)block and below are not nested inside theif (build_script)block.View this diff with whitespace disabled to see that 99% of this PR is the indentation change due to a bunch of code no longer being inside the
if (build_script)block.