[Tapioca Add-on] Limit what we require from the Rails add-on #2085
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andyw8
force-pushed
the
andyw8/limit-rails-addon-requires
branch
2 times, most recently
from
6fa9df0 to
a905779
Compare
andyw8
force-pushed
the
andyw8/limit-rails-addon-requires
branch
from
a905779 to
7f1dcdd
Compare
|
I've pushed an update, and have verified gem DSL generation on code-db. |
st0012
approved these changes
Nov 22, 2024
vinistock
approved these changes
Nov 22, 2024
There was a problem hiding this comment.
We should remove https://github.com/Shopify/ruby-lsp-rails/blob/main/lib/ruby_lsp_rails/railtie.rb. We've had the deprecation warning for long enough
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Tapioca add-on was requiring the entire
ruby-lsp-railsgem, which in turns requiresrails. As @st0012 identified, this caused a change to the behaviour of.to_jsonwhich resulted in the Dependencies view not being displayed correctly.Closes https://github.com/Shopify/team-ruby-dx/issues/1317
cc @KaanOzkan