Dashboard #194
Closed
Dashboard #194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates the router to handle `/dashboard` which will house the UI for toxiproxy.
It's not pretty but it works.
jacobbednarz
commented
Oct 23, 2017
| @@ -389,6 +392,16 @@ func (server *ApiServer) Version(response http.ResponseWriter, request *http.Req | |||
| } | |||
| } | |||
|
|
|||
| func (server *ApiServer) Dashboard(response http.ResponseWriter, request *http.Request) { | |||
| var dashboardData []proxyToxics | |||
There was a problem hiding this comment.
I made a decision early on to not use the existing HTTP API for these since we already have a couple of functions handy for fetching them.
Instead of trying to map this out myself, just reuse a combinaton of the `server.Collection.Proxies()` with `proxyWithToxics` to iterate over the available proxies and their toxics.
jacobbednarz
force-pushed
the
dashboard
branch
from
b4da338
to
f14b8e3
Compare
jacobbednarz
commented
Oct 23, 2017
| buffer: {{ .BufferSize }} | ||
| </td><td> | ||
| </td><td> | ||
| {{ if eq .Type "latency" }} |
There was a problem hiding this comment.
these if blocks will probably go away once the updating work comes into it.
|
Closing this as #218 is further along |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the start of a UI for Toxiproxy ripped heavily from the existing Shopify app but built into Toxiproxy core instead of an add-on.
Checklist
This is still verrrry WIP however I thought I would PR this early in case I either don't end up finishing it or anyone has any input during the journey.
Fixes #192