Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix tests for CI #164

Merged
merged 2 commits into from
May 10, 2024
Merged

fix tests for CI #164

merged 2 commits into from
May 10, 2024

Conversation

shivnagarajan
Copy link

run make generate_ci_workflows

similar to #148

Checklist

  • "Backport to:" labels have been added if this change should be back-ported to release branches
  • If this change is to be back-ported to previous releases, a justification is included in the PR description
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on CI?
  • Documentation was added or is not required

Deployment Notes

@shivnagarajan shivnagarajan requested a review from shanth96 May 10, 2024 14:23
@shivnagarajan
Copy link
Author

candidate build for v18 fails on some static checks

#162

https://github.com/Shopify/vitess/actions/runs/9033631811/job/24824401052?pr=162

image

this PR just runs make generate_ci_workflows as suggested.

the static tests now pass

image

@shanth96
Copy link

Wonder why unit tests are failing? flaky?

@shivnagarajan
fix tests for CI
5cf9f24 
run make generate_ci_workflows
similar to #148
remove custome machines for runs-on
run make generate_ci_workflows
use ubuntu
@shivnagarajan shivnagarajan merged commit aa73e7f into v18.0.5-shopify-1-candidate May 10, 2024
209 checks passed
shivnagarajan added a commit that referenced this pull request May 15, 2024
@shivnagarajan
Merge pull request #164 from Shopify/fix_tests_for_v18
bc37e52 
fix tests for CI

(cherry picked from commit aa73e7f)
shanth96 pushed a commit that referenced this pull request Jul 26, 2024
@shivnagarajan @shanth96
Merge pull request #164 from Shopify/fix_tests_for_v18
437b986 
fix tests for CI

(cherry picked from commit aa73e7f)
(cherry picked from commit bc37e52)
shanth96 pushed a commit that referenced this pull request Jan 13, 2025
@shivnagarajan @shanth96
Merge pull request #164 from Shopify/fix_tests_for_v18
a9d5479 
fix tests for CI

(cherry picked from commit aa73e7f)
shanth96 pushed a commit that referenced this pull request Jan 14, 2025
@shivnagarajan @shanth96
Merge pull request #164 from Shopify/fix_tests_for_v18
8639a68 
fix tests for CI

(cherry picked from commit aa73e7f)
(cherry picked from commit bc37e52)
(cherry picked from commit 437b986)
shanth96 pushed a commit that referenced this pull request Jan 14, 2025
@shivnagarajan @shanth96
Merge pull request #164 from Shopify/fix_tests_for_v18
4e977a2 
fix tests for CI

(cherry picked from commit aa73e7f)
shanth96 pushed a commit that referenced this pull request Jan 14, 2025
@shivnagarajan @shanth96
Merge pull request #164 from Shopify/fix_tests_for_v18
3f9309d 
fix tests for CI

(cherry picked from commit aa73e7f)
(cherry picked from commit bc37e52)
(cherry picked from commit 437b986)
shanth96 pushed a commit that referenced this pull request Jan 15, 2025
@shivnagarajan @shanth96
Merge pull request #164 from Shopify/fix_tests_for_v18
c58dbe8 
fix tests for CI

(cherry picked from commit aa73e7f)
shanth96 pushed a commit that referenced this pull request Jan 15, 2025
@shivnagarajan @shanth96
Merge pull request #164 from Shopify/fix_tests_for_v18
a6596a7 
fix tests for CI

(cherry picked from commit aa73e7f)
shanth96 pushed a commit that referenced this pull request Jan 15, 2025
@shivnagarajan @shanth96
Merge pull request #164 from Shopify/fix_tests_for_v18
4e813e5 
fix tests for CI

(cherry picked from commit aa73e7f)
shanth96 pushed a commit that referenced this pull request Jan 15, 2025
@shivnagarajan @shanth96
Merge pull request #164 from Shopify/fix_tests_for_v18
ecb223c 
fix tests for CI

(cherry picked from commit aa73e7f)
shanth96 pushed a commit that referenced this pull request Jan 15, 2025
@shivnagarajan @shanth96
Merge pull request #164 from Shopify/fix_tests_for_v18
3847c91 
fix tests for CI

(cherry picked from commit aa73e7f)
shanth96 pushed a commit that referenced this pull request Jan 15, 2025
@shivnagarajan @shanth96
Merge pull request #164 from Shopify/fix_tests_for_v18
f7f29c2 
fix tests for CI

(cherry picked from commit aa73e7f)
shanth96 pushed a commit that referenced this pull request Jan 15, 2025
@shivnagarajan @shanth96
Merge pull request #164 from Shopify/fix_tests_for_v18
8411814 
fix tests for CI

(cherry picked from commit aa73e7f)
shanth96 pushed a commit that referenced this pull request Jan 15, 2025
@shivnagarajan @shanth96
Merge pull request #164 from Shopify/fix_tests_for_v18
49a4a89 
fix tests for CI

(cherry picked from commit aa73e7f)
shanth96 pushed a commit that referenced this pull request Jan 15, 2025
@shivnagarajan @shanth96
Merge pull request #164 from Shopify/fix_tests_for_v18
789082e 
fix tests for CI

(cherry picked from commit aa73e7f)
shanth96 pushed a commit that referenced this pull request Jan 15, 2025
@shivnagarajan @shanth96
Merge pull request #164 from Shopify/fix_tests_for_v18
80d1ee9 
fix tests for CI

(cherry picked from commit aa73e7f)
shanth96 pushed a commit that referenced this pull request Jan 15, 2025
@shivnagarajan @shanth96
Merge pull request #164 from Shopify/fix_tests_for_v18
c1f30f4 
fix tests for CI

(cherry picked from commit aa73e7f)
shanth96 pushed a commit that referenced this pull request Jan 15, 2025
@shivnagarajan @shanth96
Merge pull request #164 from Shopify/fix_tests_for_v18
2215d2b 
fix tests for CI

(cherry picked from commit aa73e7f)
shanth96 pushed a commit that referenced this pull request Jan 17, 2025
@shivnagarajan @shanth96
Merge pull request #164 from Shopify/fix_tests_for_v18
75ff1d3 
fix tests for CI

(cherry picked from commit aa73e7f)
shanth96 pushed a commit that referenced this pull request Jan 17, 2025
@shivnagarajan @shanth96
Merge pull request #164 from Shopify/fix_tests_for_v18
8cdb915 
fix tests for CI

(cherry picked from commit aa73e7f)
(cherry picked from commit bc37e52)
(cherry picked from commit 437b986)
shanth96 pushed a commit that referenced this pull request Jan 17, 2025
@shivnagarajan @shanth96
Merge pull request #164 from Shopify/fix_tests_for_v18
9f19af0 
fix tests for CI

(cherry picked from commit aa73e7f)
(cherry picked from commit bc37e52)
(cherry picked from commit 437b986)
shanth96 pushed a commit that referenced this pull request Jan 17, 2025
@shivnagarajan @shanth96
Merge pull request #164 from Shopify/fix_tests_for_v18
cd78999 
fix tests for CI

(cherry picked from commit aa73e7f)
(cherry picked from commit bc37e52)
(cherry picked from commit 437b986)
shanth96 pushed a commit that referenced this pull request Jan 20, 2025
@shivnagarajan @shanth96
Merge pull request #164 from Shopify/fix_tests_for_v18
fa7ffa3 
fix tests for CI

(cherry picked from commit aa73e7f)
(cherry picked from commit bc37e52)
(cherry picked from commit 437b986)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shanth96 shanth96 shanth96 approved these changes

Assignees
No one assigned
Labels
Available: 15.0.5 Available: 16.0.7 Available: 17.0.6
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shivnagarajan @shanth96