Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release commit for 18.0.5-shopify-3 #178

Merged
merged 1 commit into from
Jul 25, 2024

Conversation

brendar
Copy link

@brendar brendar commented Jul 25, 2024

Updates the version identifier to include the Shopify patch number

Commands:

VTOP_VERSION=$(cat examples/operator/operator.yaml | grep -o 'planetscale/vitess-operator:v.*' | sed 's|planetscale/vitess-operator:v\(.*\)|\1|')
make BASE_BRANCH="v18.0.5-shopify-3" BASE_REMOTE="origin" RELEASE_VERSION="18.0.5-shopify-3" VTOP_VERSION=$VTOP_VERSION create_release

Result:

bin/vttestserver --version
vttestserver version Version: 18.0.5-shopify-3 (Git revision fe8cb8a5726626d6794ad316963ebc5555859c7d branch 'v18.0.5-shopify-3-create_release-1') built on Thu Jul 25 14:39:50 EDT 2024 by brendan@slab using go1.22.4 darwin/arm64
bin/vttestserver --port 4440 --keyspaces foo &


mysql --host 127.0.0.1 --port 4443 --user root
Welcome to the MySQL monitor.  Commands end with ; or \g.
Your MySQL connection id is 1
Server version: 8.0.30-Vitess Version: 18.0.5-shopify-3 (Git revision fe8cb8a5726626d6794ad316963ebc5555859c7d branch 'v18.0.5-shopify-3-create_release-1') built on Thu Jul 25 14:39:50 EDT 2024 by brendan@slab using go1.22.4 darwin/arm64

Signed-off-by: Brendan Dougherty <[email protected]>
@brendar brendar requested a review from shanth96 July 25, 2024 18:48
@brendar brendar merged commit 06dc7eb into v18.0.5-shopify-3 Jul 25, 2024
205 of 206 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants