-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump stylelint-scss to 6.3.2 #426
Conversation
Co-authored-by: Aaron Casanova <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you also update stylelint-prettier to v5, which adds support for stylelint v16 - https://github.com/prettier/stylelint-prettier/blob/main/CHANGELOG.md
Looks like stylelint-order v6.0.4 adds support for stylelint v16 as a peer dep too - https://github.com/hudochenkov/stylelint-order/blob/master/CHANGELOG.md#604
I suspect you'll also need to update jest-preset-stylelint too to fix all those failing tests
If we're going to be updating the stylelint plugin, now seems like a good time to also merge #405, which shall fix some petty dependabot security update grumbling
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice
@@ -15,16 +15,23 @@ describe('stylelint-plugin E2E Tests', () => { | |||
const result = runStylelint('value-keyword-case.*.scss'); | |||
|
|||
const expectedResult = ` | |||
Deprecation warnings: | |||
- The "scss/at-import-no-partial-leading-underscore" rule is deprecated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should fix these dependency warnings by replacing our mention of scss/at-import-no-partial-leading-underscore
with scss/load-no-partial-leading-underscore
-
'scss/at-import-no-partial-leading-underscore': true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No description provided.