Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump stylelint-scss to 6.3.2 #426

Merged
merged 7 commits into from
Jul 3, 2024
Merged

Bump stylelint-scss to 6.3.2 #426

merged 7 commits into from
Jul 3, 2024

Conversation

kyledurand
Copy link
Member

No description provided.

.vscode/settings.json Outdated Show resolved Hide resolved
@kyledurand kyledurand marked this pull request as ready for review July 3, 2024 20:11
@kyledurand kyledurand requested a review from BPScott July 3, 2024 20:19
Copy link
Member

@BPScott BPScott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also update stylelint-prettier to v5, which adds support for stylelint v16 - https://github.com/prettier/stylelint-prettier/blob/main/CHANGELOG.md

Looks like stylelint-order v6.0.4 adds support for stylelint v16 as a peer dep too - https://github.com/hudochenkov/stylelint-order/blob/master/CHANGELOG.md#604

I suspect you'll also need to update jest-preset-stylelint too to fix all those failing tests

If we're going to be updating the stylelint plugin, now seems like a good time to also merge #405, which shall fix some petty dependabot security update grumbling

Copy link

@kushp kushp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@kyledurand kyledurand merged commit 8ff1a90 into main Jul 3, 2024
4 checks passed
@kyledurand kyledurand deleted the stylelint-scss-6.3.2 branch July 3, 2024 23:09
@@ -15,16 +15,23 @@ describe('stylelint-plugin E2E Tests', () => {
const result = runStylelint('value-keyword-case.*.scss');

const expectedResult = `
Deprecation warnings:
- The "scss/at-import-no-partial-leading-underscore" rule is deprecated.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should fix these dependency warnings by replacing our mention of scss/at-import-no-partial-leading-underscore with scss/load-no-partial-leading-underscore-

'scss/at-import-no-partial-leading-underscore': true,

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants