Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

プロフィールに試合の勝敗結果を表示。 #215

Merged
merged 26 commits into from
Oct 20, 2024
Merged

プロフィールに試合の勝敗結果を表示。 #215

merged 26 commits into from
Oct 20, 2024

Conversation

subarunrun0812
Copy link
Collaborator

#202
プロフィールに試合の勝敗結果を表示。
/gamestatsページと比べてより勝敗がわかるようにした。

課題文: User profiles display stats, such as wins and losses.

image

@subarunrun0812 subarunrun0812 self-assigned this Oct 19, 2024
@subarunrun0812 subarunrun0812 changed the title feat: そのユーザーの試合の勝敗を表示 プロフィールに試合の勝敗結果を表示。 Oct 19, 2024
libknt
libknt requested changes Oct 19, 2024
View reviewed changes
Copy link
Collaborator

@libknt libknt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

作成ありがとう！
ただ、今回の課題要件として、他人のユーザーProfileを確認する際にstatsを確認できるようにという用件が入っているため、そちらも作成お願いします！

@libknt libknt marked this pull request as draft October 20, 2024 06:24
@subarunrun0812
Copy link
Collaborator Author

ありがとうございます👍🏻
課題文のここですね！

The user should be able to access other players profiles through the chat in-
terface.

対応しました！
ご確認お願いします！🙇

image

subarunrun0812
subarunrun0812 commented Oct 20, 2024
View reviewed changes
Copy link
Collaborator Author

@subarunrun0812 subarunrun0812 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

他のUserのProfileを閲覧した際に、そのUserのゲーム結果が見れるようにしました！

@subarunrun0812 subarunrun0812 marked this pull request as ready for review October 20, 2024 07:46
@subarunrun0812 subarunrun0812 requested a review from libknt October 20, 2024 07:46
soooku
soooku reviewed Oct 20, 2024
View reviewed changes
Copy link
Collaborator

@soooku soooku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

確認できました！！
リアクションゲームマージされたら勝敗結果いれてほしいです！！

@massahito massahito marked this pull request as draft October 20, 2024 09:46
@subarunrun0812 subarunrun0812 marked this pull request as ready for review October 20, 2024 11:10
@subarunrun0812 subarunrun0812 requested a review from soooku October 20, 2024 11:10
@subarunrun0812
Copy link
Collaborator Author

subarunrun0812 commented Oct 20, 2024 •
edited
Loading

https://localhost:4443/stats
gameStatsだけ、scrollできない！

@subarunrun0812
Copy link
Collaborator Author

scrollできな問題は、overflow: hiddenが設定されていたのが原因でした。以下のコミットで修正しました
ebb7860

libknt
libknt approved these changes Oct 20, 2024
View reviewed changes
Copy link
Collaborator

@libknt libknt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@libknt libknt merged commit 6766b08 into develop Oct 20, 2024
2 checks passed
@libknt libknt deleted the 202-game-stats-in-profile branch October 20, 2024 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soooku soooku soooku approved these changes

@libknt libknt libknt approved these changes

Assignees

@subarunrun0812 subarunrun0812

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@subarunrun0812 @libknt @soooku @massahito