move info to appropriate places, remove irrelevant tests

Shreyas-Ekanathan · Apr 22, 2024 · 584e4a8 · 584e4a8
1 parent c50d67b
commit 584e4a8
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 21 deletions.
diff --git a/src/algorithms.jl b/src/algorithms.jl
@@ -1213,6 +1213,23 @@ struct ERKN7 <: OrdinaryDiffEqAdaptivePartitionedAlgorithm end
 
 struct RKN4 <: OrdinaryDiffEqAlgorithm end
 
+"""
+3 stage fourth order Runge-Kutta Nystrom method to solve second order linear inhomogenous IVPs.
+
+Does not include an adaptive method. Solves for for d-dimensional differential systems of second order linear inhomogeneous equations
+## References
+
+@article{MONTIJANO2024115533,
+title = {Explicit Runge–Kutta–Nyström methods for the numerical solution of second order linear inhomogeneous IVPs},
+author = {J.I. Montijano and L. Rández and M. Calvo},
+journal = {Journal of Computational and Applied Mathematics},
+volume = {438},
+pages = {115533},
+year = {2024},
+}
+"""
+
+
 ################################################################################
 
 # Adams Bashforth and Adams moulton methods

diff --git a/src/algorithms/explicit_rk.jl b/src/algorithms/explicit_rk.jl
@@ -642,21 +642,6 @@ Base.@kwdef struct KuttaPRK2p5{TO} <: OrdinaryDiffEqAlgorithm
     threading::TO = true
 end
 
-@doc explicit_rk_docstring(
-    "3 stage fourth order Runge-Kutta Nystrom method to solve
-    second order linear inhomogenous IVPs.", "RKN4",
-    references = "J.I. Montijano, L. Rández, M. Calvo. Explicit Runge–Kutta–Nyström methods for the numerical solution of second order linear inhomogeneous IVPs
-    doi: https://www.sciencedirect.com/science/article/pii/S0377042723004776?via%3Dihub")
-Base.@kwdef struct RKN4{StageLimiter, StepLimiter, Thread} <: OrdinaryDiffEqAlgorithm
-    stage_limiter!::StageLimiter = trivial_limiter!
-    step_limiter!::StepLimiter = trivial_limiter!
-    thread::Thread = False()
-end
-
-function RKN4(stage_limiter!, step_limiter! = trivial_limiter!)
-    RKN4(stage_limiter!, step_limiter!, False())
-end
-
 @doc explicit_rk_docstring(
     "Runge–Kutta pairs of orders 9(8) for use in quadruple precision computations", "QPRK98",
     references = "Kovalnogov VN, Fedorov RV, Karpukhina TV, Simos TE, Tsitouras C. Runge–Kutta pairs 

diff --git a/test/algconvergence/partitioned_methods_tests.jl b/test/algconvergence/partitioned_methods_tests.jl
@@ -416,9 +416,6 @@ sim = test_convergence(dts, prob, FineRKN4(), dense_errors = true)
 sim = test_convergence(dts, prob, FineRKN5(), dense_errors = true)
 @test sim.𝒪est[:l2]≈5 rtol=1e-1
 @test sim.𝒪est[:L2]≈4 rtol=1e-1
-sim = test_convergence(dts, prob, RKN4(), dense_errors = true)
-@test sim.𝒪est[:l2]≈4 rtol=1e-1
-@test sim.𝒪est[:L2]≈4 rtol=1e-1
 
 # Adaptive methods regression test
 
@@ -456,9 +453,6 @@ sim = test_convergence(dts, prob, FineRKN4(), dense_errors = true)
 sim = test_convergence(dts, prob, FineRKN5(), dense_errors = true)
 @test sim.𝒪est[:l2]≈5 rtol=1e-1
 @test sim.𝒪est[:L2]≈4 rtol=1e-1
-sim = test_convergence(dts, prob, RKN4(), dense_errors = true)
-@test sim.𝒪est[:l2]≈4 rtol=1e-1
-@test sim.𝒪est[:L2]≈4 rtol=1e-1
 
 
 # Adaptive methods regression test