Upstream #11
Merged
Upstream #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This cuts out a decent loading dependency
Using:
```julia
function autocompat(ctx=Pkg.Types.Context(); io=nothing)
io = something(io, ctx.io)
updated_deps = String[]
for dep_list in (ctx.env.project.deps, ctx.env.project.weakdeps, ctx.env.project.extras),
(dep, uuid) in dep_list
compat_str = Pkg.Operations.get_compat_str(ctx.env.project, dep)
isnothing(compat_str) || continue
if uuid in ctx.env.manifest
v = ctx.env.manifest[uuid].version
v === nothing && (v = "<0.0.1, 1")
else
try
pkg_versions = Pkg.Versions.VersionSpec([Pkg.Operations.get_all_registered_versions(
ctx, uuid)...])
if isempty(pkg_versions)
@warn "No versions of $(dep) are registered. Possibly a Standard Library package."
v = "<0.0.1, 1"
else
latest_version = Pkg.Operations.get_latest_compatible_version(
ctx, uuid, pkg_versions)
v = latest_version
end
catch err
@error "Encountered Error $(err) while processing $(dep). Skipping."
continue
end
end
Pkg.Operations.set_compat(ctx.env.project, dep, string(v)) ||
Pkg.Types.pkgerror("invalid compat version specifier \"$(string(v))\"")
push!(updated_deps, dep)
end
if isempty(updated_deps)
Pkg.printpkgstyle(io, :Info, "no misssing compat entries found. No changes made.";
color=Base.info_color())
elseif length(updated_deps) == 1
Pkg.printpkgstyle(io, :Info,
"new entry set for $(only(updated_deps)) based on its current version";
color=Base.info_color())
else
Pkg.printpkgstyle(io,
:Info,
"new entries set for $(join(updated_deps, ", ", " and ")) based on their current versions";
color=Base.info_color())
end
Pkg.Types.write_env(ctx.env)
return Pkg.Operations.print_compat(ctx; io)
end
for x in readdir("/Users/chrisrackauckas/.julia/dev/OrdinaryDiffEq/lib")
Pkg.activate("/Users/chrisrackauckas/.julia/dev/OrdinaryDiffEq/lib/$x")
autocompat()
end
```
Autocompat
Remove the InteractiveUtils dependency by reimplementing subtypes
Split and inactivate increment functions
This was used as a performance optimization early on, dropping the construction of those two vectors since we already construct so much in the caches, we might as well reuse one of the cache pointers. And it's also built into some methods what cache pointer that must be. So the integrator is made with undef's and then during initialization phase the pointers are set. However, this is unnecessary and adds some complexity. For one, it makes the constructor a bit of a mess. But for two, it gives Enzyme issues as demonstrated in SciML#2282. A better solution is then to just, construct the type correctly. To do this, we simply need to refactor the information of what vectors correspond to fsal first and last into a function that is per-cache, and use that function in the integrator construction. That's already done in this PR. All that's required to complete this PR is to ensure this refactor is done on every method.
add tstops API
Refactor ODEIntegrator to not allow undef fsal states
fix oop BDF gamma type and terk_tmp type
update firk order
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.