Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] Added Contributors List #124

Merged
merged 3 commits into from
Jan 24, 2024
Merged

[FEAT] Added Contributors List #124

merged 3 commits into from
Jan 24, 2024

Conversation

rishicds
Copy link
Contributor

@rishicds rishicds commented Jan 22, 2024

Fixes #117

I have added a new contributor section in the about page, it will automatically update when new contributors give PRs.
The contributor list can be changed by editing contributors.json,
Clicking on their names will redirect them to their github profiles.

image

Copy link

netlify bot commented Jan 22, 2024

Deploy Preview for swetify ready!

Name Link
🔨 Latest commit c0c2261
🔍 Latest deploy log https://app.netlify.com/sites/swetify/deploys/65aee5cd790009000850eb49
😎 Deploy Preview https://deploy-preview-124--swetify.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@rishicds
Copy link
Contributor Author

Please take a look @ShwetKhatri2001

@ShwetKhatri2001
Copy link
Owner

Can you fetch the contributors list from GitHub API instead of our json ? It would be much better.

@rishicds
Copy link
Contributor Author

Ok, I'ill give it a shot @ShwetKhatri2001

@rishicds
Copy link
Contributor Author

rishicds commented Jan 22, 2024

image

Hi, this now displays all the contributors,please check @ShwetKhatri2001 , I have added the Github API

Copy link
Owner

@ShwetKhatri2001 ShwetKhatri2001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉 Congrats @rishicds on your first PR getting merged on Swetify-Music 🚀. Keep Contributing 👍 .

Assigning Medium level for putting extra efforts on this PR.

@ShwetKhatri2001 ShwetKhatri2001 merged commit e4d8f63 into ShwetKhatri2001:master Jan 24, 2024
6 checks passed
@ShwetKhatri2001 ShwetKhatri2001 added feature Medium medium level issue SWOC S4 Assigned to SWOC S4 Contributor labels Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Medium medium level issue SWOC S4 Assigned to SWOC S4 Contributor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Add Contributor Section
2 participants