Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arijit singh and Hollywood songs playlist #135

Merged
merged 3 commits into from
Feb 6, 2024

Conversation

divyeshpillai7
Copy link
Contributor

@divyeshpillai7 divyeshpillai7 commented Feb 3, 2024

Fixes #69
updated hollywood songs and arijit singh playlist. Also made some changes to the music player UI

Copy link

netlify bot commented Feb 3, 2024

Deploy Preview for swetify ready!

Name Link
🔨 Latest commit 583d7be
🔍 Latest deploy log https://app.netlify.com/sites/swetify/deploys/65bf7475e9929a000853d8ba
😎 Deploy Preview https://deploy-preview-135--swetify.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@divyeshpillai7
Copy link
Contributor Author

Hi @ShwetKhatri2001, I created a new pull request as the previous one had some issues. I guess the homepage was updated with a few additions of the Hamburger panel and stuff. So, I have updated my pages that adapts with the new changes made. I have also re-designed the music player as you said, but still some changes has to be made. You can now merge this PR as there are no merge conflicts as well and we can work on the other improvements you mentioned in an other PR :)

@ShwetKhatri2001
Copy link
Owner

ShwetKhatri2001 commented Feb 4, 2024

Yes, your playlist pages are good to be merged. But your changes on the player are affecting other pages where we don't have playlist pages.
Keep your player implementation separate for now. You will get a hard level assigned for making these changes.
We will have playlist pages for all playlists as part of #61 later once we finalize it completely.

image

Also, change the title on this page to Best of Arijit Singh

image

@divyeshpillai7
Copy link
Contributor Author

@ShwetKhatri2001, I've made the mentioned changes. I've taken back all the changes I'd made to the music player. Now its the same as before. Also, I've updated the titles of the pages.

Copy link
Owner

@ShwetKhatri2001 ShwetKhatri2001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉 Congrats @divyeshpillai7 on your first PR getting merged on Swetify-Music 🚀. Keep Contributing 👍 .

@ShwetKhatri2001 ShwetKhatri2001 merged commit ecaafd7 into ShwetKhatri2001:master Feb 6, 2024
6 checks passed
@ShwetKhatri2001 ShwetKhatri2001 added feature Medium medium level issue SWOC S4 Assigned to SWOC S4 Contributor labels Feb 6, 2024
@divyeshpillai7
Copy link
Contributor Author

@ShwetKhatri2001 Thanks a lot!!❤️😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Medium medium level issue SWOC S4 Assigned to SWOC S4 Contributor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update the Artist Playlists (Arijit Singh)
2 participants