-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Arijit singh and Hollywood songs playlist #135
Conversation
✅ Deploy Preview for swetify ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Hi @ShwetKhatri2001, I created a new pull request as the previous one had some issues. I guess the homepage was updated with a few additions of the Hamburger panel and stuff. So, I have updated my pages that adapts with the new changes made. I have also re-designed the music player as you said, but still some changes has to be made. You can now merge this PR as there are no merge conflicts as well and we can work on the other improvements you mentioned in an other PR :) |
Yes, your playlist pages are good to be merged. But your changes on the player are affecting other pages where we don't have playlist pages. Also, change the title on this page to |
@ShwetKhatri2001, I've made the mentioned changes. I've taken back all the changes I'd made to the music player. Now its the same as before. Also, I've updated the titles of the pages. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉 Congrats @divyeshpillai7 on your first PR getting merged on Swetify-Music 🚀. Keep Contributing 👍 .
@ShwetKhatri2001 Thanks a lot!!❤️😊 |
Fixes #69
updated hollywood songs and arijit singh playlist. Also made some changes to the music player UI