Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Global optimized SWG to strip #111

Merged
merged 8 commits into from
Jul 15, 2024
Merged

Global optimized SWG to strip #111

merged 8 commits into from
Jul 15, 2024

Conversation

SK747
Copy link
Contributor

@SK747 SK747 commented Jul 15, 2024

Just some passive devices for possible future publication on global opt devices

@SK747
Copy link
Contributor Author

SK747 commented Jul 15, 2024

no EO testing is necessary

@lukasc-ubc
Copy link
Member

Please put all your Si geometries on the Si layer. See the layer table in the Readme file. Your taper won't get manufactured as is:

image

@lukasc-ubc lukasc-ubc added the bug Something isn't working label Jul 15, 2024
@SK747
Copy link
Contributor Author

SK747 commented Jul 15, 2024

Sorry about that Lukas. I didnt notice. I fixed them

@lukasc-ubc lukasc-ubc merged commit ddec0bc into SiEPIC:main Jul 15, 2024
1 of 2 checks passed
@lukasc-ubc
Copy link
Member

Unfortunately your layout size is incorrect. So I have to revert the commit. Please submit on the next run.

image

lukasc-ubc added a commit that referenced this pull request Jul 16, 2024
lukasc-ubc added a commit that referenced this pull request Jul 16, 2024
@lukasc-ubc
Copy link
Member

I fixed it for you.

@SK747
Copy link
Contributor Author

SK747 commented Jul 16, 2024

Thanks a lot! Very sorry about that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants