retry adding new designs #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Submit a new version of design from aborted commits. Uses the GCs and electrical pads from the example EBeam_heaters_BraggGratingwithHeater.gds example. YAML file is a stub (copy of the example EBeam_heaters_BraggGratingwithHeater.yaml).
Moved the optical text label to the location in the example (EBeam_heaters_BraggGratingwithHeater.gds).
Add DevRec bounding box to custom component.
Move heater segments inside cell MZI_Ring_2_2 in attempt to address DRC issue.
This version should be free from DRC errors (V and D), except for nuisance errors.
This version should be free from DRC errors (V and D), except for nuisance errors.
|
Running verification on EBeam_heaters_snewman_RMA3.gds |
remove extra top cell
|
I deleted the extra top cell, and now we are ready to merge! |
|
@lukasc-ubc thanks very much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DRC issues with the previous submission of these designs should be addressed.