Check if console widget is active before refitting terminal canvas

Sienci-Labs · Dec 19, 2023 · 4202aa5 · 4202aa5
1 parent d759835
commit 4202aa5
Showing 1 changed file with 4 additions and 12 deletions.
diff --git a/src/app/widgets/Console/Terminal.jsx b/src/app/widgets/Console/Terminal.jsx
@@ -115,7 +115,6 @@ class TerminalWrapper extends PureComponent {
         this.term.loadAddon(this.fitAddon);
         this.term.prompt = () => {
             this.term.write('\r\n');
-            //this.term.write(color.white(this.prompt));
         };
 
         const el = ReactDOM.findDOMNode(this.terminalContainer);
@@ -143,11 +142,9 @@ class TerminalWrapper extends PureComponent {
     }
 
     componentDidUpdate(_, prevState) {
-        if (this.props.active) {
-            setTimeout(() => {
-                this.refitTerminal();
-            }, 150);
-        }
+        setTimeout(() => {
+            this.refitTerminal();
+        }, 150);
 
         if (this.state.terminalInputIndex !== prevState.terminalInputIndex) {
             const { terminalInputHistory } = this.state;
@@ -156,8 +153,6 @@ class TerminalWrapper extends PureComponent {
                 return;
             }
 
-            // const inputSize = [...terminalInputHistory[this.state.terminalInputIndex] || ''].length;
-
             this.inputRef.current.focus();
             this.inputRef.current.value = terminalInputHistory[this.state.terminalInputIndex] || '';
         }
@@ -203,7 +198,7 @@ class TerminalWrapper extends PureComponent {
     }
 
     refitTerminal() {
-        if (this.fitAddon) {
+        if (this.fitAddon && this.props.active) {
             this.fitAddon.fit();
         }
     }
@@ -283,9 +278,6 @@ class TerminalWrapper extends PureComponent {
         const rs = reduxStore.getState();
         const selection = get(rs, 'controller.terminalHistory');
         const text = selection.slice(-LINES_TO_COPY).join('\n');
-        //this.term.selectAll();
-        //const selection = this.term.getSelection().split('\n');
-        //this.term.clearSelection();
 
         if (isElectron()) {
             window.ipcRenderer.send('clipboard', text);