[MIRROR] Improves parapen feedback #1058
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Оригинальный PR: Baystation12#34176
A bug was reported that parapens weren't working. Turns out they were working, they just had HORRIBLE feedback. I suspect this is because the old attack() procs that were moved to use_weapon() used to handle feedback.
This was fixed. You now get feedback if you inject someone with any intent. If you inject with harm intent, it will play the regular use_weapon attack animation, sounds, and feedback while also injecting someone. If you inject with any other intent, it will give 'You prick X with the pen'/'you feel a tiny prick' feedback.
If the reagent pen is empty, the entire attack() proc is skipped and it will go through the rest of resolve_attackby. This fixes not being able to use an empty parapen offensively, in case you want to stab eyes out with it. (Which is a thing since the eyestab overhaul!)